refactor: Prepare for moving ArgsManager out of util/system #24811

1. 
   Empact commented at 7:36 pm on April 8, 2022: member

   This comprises the preparation commits for #24455, which are relatively succinct, for easier review.
2. Empact marked this as a draft on Apr 8, 2022
3. DrahtBot added the label Block storage on Apr 8, 2022
4. DrahtBot added the label Build system on Apr 8, 2022
5. DrahtBot added the label GUI on Apr 8, 2022
6. DrahtBot added the label P2P on Apr 8, 2022
7. DrahtBot added the label Refactoring on Apr 8, 2022
8. DrahtBot added the label RPC/REST/ZMQ on Apr 8, 2022
9. DrahtBot added the label Utils/log/libs on Apr 8, 2022
10. DrahtBot added the label UTXO Db and Indexes on Apr 8, 2022
11. DrahtBot added the label Validation on Apr 8, 2022
12. DrahtBot added the label Wallet on Apr 8, 2022
13. 
    DrahtBot commented at 11:09 pm on April 9, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25083 (Set effective_value when initializing a COutput by ishaanam)
    • #24845 (wallet: createTransaction, return proper error description for “too-long-mempool-chain” + introduce generic Result classes by furszy)
    • #24757 (build, ci: add DEBUG_LOCKCONTENTION to –enable-debug and CI by jonatack)
    • #24676 ([WIP] [kernelheaders 1/n] Cleave LevelDB headers from our header tree by dongcarl)
    • #24675 (util: Use ArgsManager::GetPathArg more widely by hebasto)
    • #24232 (assumeutxo: add init and completion logic by jamesob)
    • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)
    • #23561 (BIP324: Handshake prerequisites by dhruv)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. Empact force-pushed on Apr 15, 2022
15. Empact marked this as ready for review on Apr 15, 2022
16. refactor: Don't reference gArgs inside of CCoinControl

    This changes the wallet tests to rely on BasicTestingSetup#m_args
    rather than gArgs, which seems more appropriate.

    7af48eb8d2
17. refactor: Don't reference gArgs inside of CheckDataDirOption 2bab5a4740
18. refactor: Call ClearPathCache/CheckDataDirOption on the current args, not gArgs

    In ArgsManager::ReadConfigFiles, we're operating on an ArgsManager - modifying
    gArgs is incongruous.

    5f214be3b7
19. refactor: Don't reference gArgs inside AbsPathForConfigVal & GetConfigFile 94a4ac0474
20. refactor: Move error from util/system.h to logging.h cfff4b78bf
21. refactor: Don't reference gArgs in SelectBaseParams 3b8999a21b
22. Empact force-pushed on Apr 17, 2022
23. laanwj removed the label GUI on Apr 21, 2022
24. laanwj removed the label Wallet on Apr 21, 2022
25. laanwj removed the label Build system on Apr 21, 2022
26. laanwj removed the label UTXO Db and Indexes on Apr 21, 2022
27. laanwj removed the label RPC/REST/ZMQ on Apr 21, 2022
28. laanwj removed the label P2P on Apr 21, 2022
29. laanwj removed the label Validation on Apr 21, 2022
30. laanwj removed the label Block storage on Apr 21, 2022
31. refactor: Drop unused logging includes from addrman_impl.h

    These were introduced in #22950, but they're not used in the header,
    rather equivalent includes in addrman.cpp do the work.

    f396b3d3fd
32. refactor: Remove util/system.h from dbwrapper.h

    This file is not required for the dbwrapper interfaces provided, but several other files were getting their necessary includes indirectly via this header.
    
    Removing results in more minimal includes throughout.

    45485fcf95
33. refactor: Remove logging.h include from net.h b1fbcc8ead
34. refactor: Include logging rather than util/system in banman.cpp

    This is the more minimal include, and the only used therein.

    fd9bfdab74
35. 
    DrahtBot commented at 7:38 am on May 13, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

36. DrahtBot added the label Needs rebase on May 13, 2022
37. 
    Empact commented at 5:57 pm on May 15, 2022: member

    Going to rework given inattention.
38. Empact closed this on May 15, 2022

    ---

39. Empact deleted the branch on May 15, 2022
40. Empact restored the branch on Nov 18, 2022
41. bitcoin locked this on Nov 18, 2023

Contributors
Empact DrahtBot

Labels
Refactoring Utils/log/libs Needs rebase