Hopefully closes #24373 by calling ConnmanTestMsg test-constructor to avoid undefined behavior in process_message.cpp after casting g_setup->m_node.connman.
test: fix connman UB by calling derived constructor #24841
pull chinggg wants to merge 1 commits into bitcoin:master from chinggg:fix-test-connman-ub changing 1 files +4 −3-
chinggg commented at 12:15 PM on April 13, 2022: contributor
- fanquake added the label Tests on Apr 13, 2022
-
chinggg commented at 12:25 PM on April 13, 2022: contributor
I have kept the order of included header files since
CONTRIBUTING.mdsuggests style fixes should be separate. -
DrahtBot commented at 2:54 PM on April 13, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22910 (net: Encapsulate asmap in NetGroupManager by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
MarcoFalke commented at 11:22 AM on April 15, 2022: member
I have kept the order of included header files since CONTRIBUTING.md suggests style fixes should be separate.
include lines are unlikely to be touched for other reasons, unless the included file is renamed, so personally I think it is fine to sort them when one of the include lines of the file is touched
- chinggg force-pushed on Apr 15, 2022
- chinggg force-pushed on Apr 16, 2022
-
test: fix connman UB by calling derived constructor c848a45101
- chinggg force-pushed on Apr 16, 2022
- joshuadbryant1985 approved
- MarcoFalke merged this on Apr 16, 2022
- MarcoFalke closed this on Apr 16, 2022
- sidhujag referenced this in commit 1b61ec001a on Apr 18, 2022
- chinggg deleted the branch on Apr 23, 2022
- DrahtBot locked this on Apr 23, 2023
Contributors
Labels