[23.x] rc5 backports #24843

1. 
   fanquake commented at 1:09 PM on April 13, 2022: member

   Currently backports:

   • https://github.com/bitcoin/bitcoin/pull/24842
2. guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues

   This commit backports a patch to the GCC 10.3.0 we build for Windows
   cross-compilation in Guix. The commit has been backported to the GCC
   releases/gcc-10 branch, but hasn't yet made it into a release.
   
   The patch corrects a regression from an earlier GCC commit, see:
   https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=357c4350680bf29f0c7a115424e3da11c53b5582
   and
   https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=074226d5aa86cd3de517014acfe34c7f69a2ccc7,
   related to the way newer versions of mingw-w64 implement setjmp/longjmp.
   
   Ultimately this was causing a crash for us when Windows users were
   viewing the network traffic tab inside the GUI. After some period, long
   enough that a buffer would need reallocating, a call into FreeTypes
   gray_record_cell() would result in a call to ft_longjmp (longjmp), which
   would then trigger a crash.
   
   Fixes: https://github.com/bitcoin-core/gui/issues/582.
   
   See also:
   https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e8d1ca7d2c344a411779892616c423e157f4aea8.
   https://bugreports.qt.io/browse/QTBUG-93476.
   
   Github-Pull: #24842
   Rebased-From: 457148a803cee02897b7428fa7b3eb93eed71e4c

   a75b8ec836
3. fanquake added the label Backport on Apr 13, 2022
4. fanquake added this to the milestone 23.0 on Apr 13, 2022
5. hebasto approved
6. 
   hebasto commented at 1:38 PM on April 13, 2022: member

   ACK a75b8ec836a5a5c08aebaf2efd99d5c34d033292

7. 
   jonatack commented at 1:49 PM on April 13, 2022: member

   Code review and commit meta-data ACK a75b8ec836a5a5c08aebaf2efd99d5c34d033292

8. 
   gruve-p commented at 1:49 PM on April 13, 2022: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/24843/commits/a75b8ec836a5a5c08aebaf2efd99d5c34d033292

9. jarolrod approved
10. 
    jarolrod commented at 1:58 AM on April 14, 2022: member

    ACK a75b8ec836a5a5c08aebaf2efd99d5c34d033292

11. laanwj merged this on Apr 14, 2022
12. laanwj closed this on Apr 14, 2022

    ---

13. fanquake deleted the branch on Apr 14, 2022
14. DrahtBot locked this on Apr 14, 2023

Milestone
23.0