contrib: Remove suspicious hosts list from makeseeds #24862

1. 
   laanwj commented at 12:16 pm on April 15, 2022: member

   I have some qualms about maintaining a suspicious hosts list as part as the repository*. But also, it’s stale and irrelevant. I’ve checked the entire list and none of them is connectable. Only one still appars in nodes_main.txt but with low uptime and an old subversion string so it wouldn’t be picked in the first place. This change removes the list and the functionality to use it.

   IP	8333 connectable	in nodes_main.txt
   130.211.129.106	no	no
   148.251.238.178	no	no
   176.9.46.6	no	yes: /Satoshi:0.9.2.1/
   178.63.107.226	no	no
   54.173.72.127	no	no
   54.174.10.182	no	no
   54.183.64.54	no	no
   54.194.231.211	no	no
   54.66.214.167	no	no
   54.66.220.137	no	no
   54.67.33.14	no	no
   54.77.251.214	no	no
   54.94.195.96	no	no
   54.94.200.247	no	no
   83.81.130.26	no	no
   88.198.17.7	no	no

   ref: #17020 (comment)

   * besides the commit noise, potential legal issues around accountability and liability that would come with maintaining such a blocklist actively, I don’t think we should expose the project to

2. contrib: Remove suspicious hosts list from makeseeds

   I have some qualms with maintaining a suspicious hosts list as part as
   the repository. But also, it's stale and irrelevant. I've checked the
   entire list and none of them is connectable. Only one still appars in
   `nodes_main.txt` but with low uptime and an old subversion string so it
   wouldn't be picked in the first place.

   2f629f8089
3. laanwj added the label Scripts and tools on Apr 15, 2022
4. 
   mruddy commented at 12:43 pm on April 15, 2022: contributor

   Concept ACK this seems like not very effective cat and mouse stuff. I also looked through the code and the proposed change looks comprehensive / complete.
5. jonatack approved
6. 
   jonatack commented at 1:07 pm on April 15, 2022: member

   ACK 2f629f80896697e458b47a8335744a11b4f3358

   It looks like these haven’t been updated since be22b3da1df15757ef15e4c4963507bcdff6a872 in December 2014/January 2015.

7. unknown approved
8. 
   unknown commented at 6:01 pm on April 15, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/24862/commits/2f629f80896697e458b47a8335744a11b4f33587
9. 
   MarcoFalke commented at 6:07 pm on April 15, 2022: member

   ACK
10. 
    Empact commented at 7:01 pm on April 15, 2022: member

    ACK https://github.com/bitcoin/bitcoin/pull/24862/commits/2f629f80896697e458b47a8335744a11b4f33587

    /cc @sipa, who introduced this list in be22b3da1df15757ef15e4c4963507bcdff6a872

11. fanquake merged this on Apr 18, 2022
12. fanquake closed this on Apr 18, 2022

    ---

13. Fabcien referenced this in commit 555fc65e89 on Oct 5, 2022
14. DrahtBot locked this on Apr 18, 2023

Contributors
laanwj mruddy jonatack MarcoFalke Empact

Labels
Scripts and tools