contrib: improve makeseeds.py progress indicator #24863

1. 
   jonatack commented at 2:22 pm on April 15, 2022: member

   Follow-up to #24818.

   before

    0  IPv4   IPv6  Onion Pass
    1470813  73279      0 Initial
    2470813  73279      0 Skip entries with invalid address
    3470813  73279      0 After removing duplicates
    4470812  73279      0 Skip entries from suspicious hosts
    5  6340   1733      0 Enforce minimal number of blocks
    6  5480   1490      0 Require service bit 1
    7  3892    880      0 Require minimum uptime
    8  3818    856      0 Require a known and recent user agent
    9  3789    848      0 Filter out hosts with multiple bitcoin ports
   10   160 / 4637 [03.5%]       <- user wonders what is happening now and a leading zero is printed
   11   512    512      0 Look up ASNs and limit results per ASN and per net
   

   after

    0470813  73279      0 Initial
    1470813  73279      0 Skip entries with invalid address
    2470813  73279      0 After removing duplicates
    3470812  73279      0 Skip entries from suspicious hosts
    4  6340   1733      0 Enforce minimal number of blocks
    5  5480   1490      0 Require service bit 1
    6  3892    880      0 Require minimum uptime
    7  3818    856      0 Require a known and recent user agent
    8  3789    848      0 Filter out hosts with multiple bitcoin ports
    9                     Look up ASNs and limit results per ASN and per net:   160 / 4637 (3.5%)
   10   512    512      0 Look up ASNs and limit results per ASN and per net  <- replaces previous line when done
   

2. jonatack force-pushed on Apr 15, 2022
3. contrib: improve makeseeds.py progress indicator e937121416
4. jonatack force-pushed on Apr 15, 2022
5. DrahtBot added the label Scripts and tools on Apr 15, 2022
6. 
   laanwj commented at 3:50 pm on April 15, 2022: member

   Concept ACK. Though not sure we still need a progress indicator after #24864, lookup is really really fast with asmap.
7. 
   jonatack commented at 3:58 pm on April 15, 2022: member

   Even better then, will test.
8. 
   vincenzopalazzo commented at 9:16 pm on April 15, 2022: none

   Concept ACK
9. 
   DrahtBot commented at 6:42 am on April 16, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24864 (contrib: Use asmap for ASN lookup in makeseeds by laanwj)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. 
    jonatack commented at 8:39 pm on April 18, 2022: member

    Concept ACK. Though not sure we still need a progress indicator after #24864, lookup is really really fast with asmap.

    After testing it, yes it might be better to remove the indicator there and maybe add one when loading the seed data.

11. 
    fanquake commented at 8:48 pm on April 18, 2022: member

    Great. Lets close this for now then, and keep the commentary / removal / figuring out if we even need a progress indicator in #24864.
12. fanquake closed this on Apr 18, 2022

    ---

13. 
    jonatack commented at 9:06 pm on April 18, 2022: member

    That’s not really what that pull is currently about, though, so I thought this one could be updated after. Oh well.
14. 
    fanquake commented at 9:18 pm on April 18, 2022: member

    That’s not really what that pull is currently about, though, so I thought this one could be updated after. Oh well.

    The pull doesn’t only have to be about the progress indicator, to make decisions about it’s existence. Given the changes, one of the side-effects may be that we just no longer need the progress indicator, so it probably make sense for that discussion/change to happen in that PR. Rather than following up again afterwards.

15. 
    jonatack commented at 9:26 pm on April 18, 2022: member

    Maybe let that process happen naturally?
16. DrahtBot locked this on Apr 18, 2023

Contributors
jonatack laanwj vincenzopalazzo DrahtBot fanquake

Labels
Scripts and tools