contrib: improve makeseeds.py progress indicator #24863

Follow-up to #24818.

before

  IPv4   IPv6  Onion Pass
470813  73279      0 Initial
470813  73279      0 Skip entries with invalid address
470813  73279      0 After removing duplicates
470812  73279      0 Skip entries from suspicious hosts
  6340   1733      0 Enforce minimal number of blocks
  5480   1490      0 Require service bit 1
  3892    880      0 Require minimum uptime
  3818    856      0 Require a known and recent user agent
  3789    848      0 Filter out hosts with multiple bitcoin ports
   160 / 4637 [03.5%]       <- user wonders what is happening now and a leading zero is printed
   512    512      0 Look up ASNs and limit results per ASN and per net

after

470813  73279      0 Initial
470813  73279      0 Skip entries with invalid address
470813  73279      0 After removing duplicates
470812  73279      0 Skip entries from suspicious hosts
  6340   1733      0 Enforce minimal number of blocks
  5480   1490      0 Require service bit 1
  3892    880      0 Require minimum uptime
  3818    856      0 Require a known and recent user agent
  3789    848      0 Filter out hosts with multiple bitcoin ports
                     Look up ASNs and limit results per ASN and per net:   160 / 4637 (3.5%)
   512    512      0 Look up ASNs and limit results per ASN and per net  <- replaces previous line when done

Concept ACK. Though not sure we still need a progress indicator after #24864, lookup is really really fast with asmap.

Even better then, will test.

Concept ACK

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #24864 (contrib: Use asmap for ASN lookup in makeseeds by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Concept ACK. Though not sure we still need a progress indicator after #24864, lookup is really really fast with asmap.

After testing it, yes it might be better to remove the indicator there and maybe add one when loading the seed data.

Great. Lets close this for now then, and keep the commentary / removal / figuring out if we even need a progress indicator in #24864.

That's not really what that pull is currently about, though, so I thought this one could be updated after. Oh well.

That's not really what that pull is currently about, though, so I thought this one could be updated after. Oh well.

The pull doesn't only have to be about the progress indicator, to make decisions about it's existence. Given the changes, one of the side-effects may be that we just no longer need the progress indicator, so it probably make sense for that discussion/change to happen in that PR. Rather than following up again afterwards.

Maybe let that process happen naturally?