miniscript: the ’d:’ wrapper must not be ‘u’ #24906

1. 
   darosior commented at 2:10 pm on April 18, 2022: member

   The type system was incorrectly relying on a standardness rule to be sound.

   This bug was found and reported by Andrew Poelstra based on a question from Aman Kumar Kashyap.

2. miniscript: the 'd:' wrapper must not be 'u'

   The value it leaves on the stack depends on the last element on the
   stack. However, we can't make sure this element is OP_1 (which would
   give us the 'u' property) without the MINIMALIF rule.
   MINIMALIF is only policy for P2WSH, therefore giving 'd:' the 'u'
   property breaks consensus soundness: it makes it possible (by consensus
   but not policy) for instance to satisfy a thresh() without satisfying
   at least k of its subs.
   
   This bug was found and reported by Andrew Poelstra.

   7417594187
3. DrahtBot added the label Tests on Apr 18, 2022
4. 
   sipa commented at 5:45 pm on April 18, 2022: member

   ACK 74175941870347458ba8a0074f88b22cb94d0235
5. 
   DrahtBot commented at 2:15 am on April 19, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24860 (Miniscript integration follow-ups by darosior)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   fanquake commented at 7:54 am on April 19, 2022: member

   cc @sanket1729 @apoelstra
7. 
   apoelstra commented at 5:02 pm on April 19, 2022: contributor

   utACK 74175941870347458ba8a0074f88b22cb94d0235
8. 
   achow101 commented at 5:16 pm on April 19, 2022: member

   ACK 74175941870347458ba8a0074f88b22cb94d0235
9. hebasto merged this on Apr 19, 2022
10. hebasto closed this on Apr 19, 2022

    ---

11. 
    sanket1729 commented at 6:05 pm on April 19, 2022: contributor

    ACK 74175941870347458ba8a0074f88b22cb94d0235
12. darosior deleted the branch on Apr 19, 2022
13. sidhujag referenced this in commit 90e2d30092 on Apr 19, 2022
14. DrahtBot locked this on Apr 19, 2023

Contributors
darosior sipa DrahtBot fanquake apoelstra achow101 sanket1729

Labels
Tests