Make BlockManager::LoadBlockIndex private #24917

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-priv-🔚 changing 2 files +7 −9

MarcoFalke commented at 9:37 AM on April 19, 2022: member
- After commit fa27f03b4943540aa2eab283d4cf50ad4a1a01f8 BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private.
- After commit c600ee38168a460d3026eae0e289c976194aad14 m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed.
Make BlockManager::LoadBlockIndex private fa1970f075
MarcoFalke added the label Refactoring on Apr 19, 2022
mruddy commented at 10:56 AM on April 19, 2022: contributor

ACK fa1970f075292d7312654730a994a68c2ca8bc06 I verified by double checking references, then applying the patch, and running make check. LGTM.
DrahtBot commented at 5:08 PM on April 19, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24595 (deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns)
- #22564 (refactor: Move mutable globals cleared in ::UnloadBlockIndex to BlockManager by dongcarl)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake commented at 7:13 PM on April 26, 2022: member

Looking at the bot. #24595 is now based on #22564, and #22564 needs rebase. So going to merge this.
fanquake merged this on Apr 26, 2022
fanquake closed this on Apr 26, 2022
MarcoFalke deleted the branch on Apr 27, 2022
sidhujag referenced this in commit 82b8e545ee on Apr 29, 2022
Fabcien referenced this in commit 9c56576e4d on Jan 28, 2023
DrahtBot locked this on Apr 27, 2023

Contributors

Labels

Make BlockManager::LoadBlockIndex private #24917

Conflicts