Remove not needed clang-format off comments #24959

1. 
   MarcoFalke commented at 2:37 pm on April 24, 2022: member

   It seems odd to disable clang-format and force manual formatting when there is no need for it. So remove the clang-format comments and other unneeded comments.

   Can be reviewed with --word-diff-regex=. --ignore-all-space

   Looks like this was initially added in commit d9d79576f423cd9c5cef4547c7e3648dbb339460 to accommodate a linter that has since been removed and replaced by a functional test.

2. MarcoFalke added the label Refactoring on Apr 24, 2022
3. 
   DrahtBot commented at 0:58 am on April 25, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23549 (Add scanblocks RPC call (attempt 2) by jamesob)
   • #23417 (wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101)
   • #23387 (WIP: add support to save fee estimates without having to shut down the node by greenaddress)
   • #22751 (rpc/wallet: add simulaterawtransaction RPC by kallewoof)
   • #19792 (rpc: Add dumpcoinstats by fjahr)
   • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. MarcoFalke force-pushed on Apr 25, 2022
5. Remove not needed clang-format off comments

   Can be reviewed with --word-diff-regex=. --ignore-all-space

   fa870e3d4c
6. vincenzopalazzo approved
7. 
   vincenzopalazzo commented at 9:14 am on April 25, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/24959/commits/faa9392e7ec5a1c9e26584063bd47a2b18721142
8. MarcoFalke force-pushed on Apr 25, 2022
9. 
   MarcoFalke commented at 1:02 pm on April 25, 2022: member

   Force pushed to remove an empty line
10. fanquake approved
11. 
    fanquake commented at 9:51 am on April 26, 2022: member

    ACK fa870e3d4ccd6dfd0a9a8f2c608721a7251114e2
12. 
    laanwj commented at 1:09 pm on April 26, 2022: member

    Code review ACK fa870e3d4ccd6dfd0a9a8f2c608721a7251114e2

    Looks like this was initially added in commit https://github.com/bitcoin/bitcoin/commit/d9d79576f423cd9c5cef4547c7e3648dbb339460 to accommodate a linter

    Yes, also the table used to have more columns, so the grid based formatting helped make it legible.

13. laanwj merged this on Apr 26, 2022
14. laanwj closed this on Apr 26, 2022

    ---

15. sidhujag referenced this in commit 86f62810e1 on Apr 26, 2022
16. MarcoFalke deleted the branch on Apr 27, 2022
17. DrahtBot locked this on Apr 27, 2023

Contributors
MarcoFalke DrahtBot vincenzopalazzo fanquake laanwj

Labels
Refactoring