Update bitcoin.conf #24969

pull BradleyC wants to merge 2 commits into bitcoin:master from BradleyC:patch-1 changing 1 files +4 −0

BradleyC commented at 9:45 AM on April 25, 2022: none

Add txindex to miscellaneous config options.

As a developer migrating from Ethereum to BTC development, it's incredibly useful to see this option in the default config rather than discovering the option later and having to reindex, reboot development stack, etc.

Update bitcoin.conf

Add txindex to miscellaneous config options.

d3f3f0ce52

DrahtBot commented at 9:50 AM on April 25, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22235 (script: add script to generate example bitcoin.conf by josibake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
josibake commented at 10:18 AM on April 25, 2022: member

hi @BradleyC , I've proposed #22235 as a "once and for all" solution to this problem. The idea is to generate a config file from the bitcoind help output so that every config option is documented and kept up-to-date with each Bitcoin Core release. Would love to have your input on the PR
in share/examples/bitcoin.conf:159 in d3f3f0ce52 outdated
```
 155 | @@ -156,6 +156,9 @@
 156 |  # Maintain coinstats index used by the gettxoutsetinfo RPC (default: 0).
 157 |  #coinstatsindex=1
 158 |  
 159 | +# Maintain the transaction index, which is useful for exploration and development.
```
evanlinjin commented at 10:22 AM on April 25, 2022:

I would be a bit more descriptive here: "Maintain transaction index for all transactions."

Bitcoin Core by default maintains transaction indexes for "relevant" transactions: https://bitcoin.stackexchange.com/a/37979
BradleyC commented at 11:14 AM on April 25, 2022: none

Issue #22235 addresses this use case much more elegantly, when that PR gets merged this would become irrelevant.
Update bitcoin.conf
updated text for clarity
d800211404
laanwj added the label Docs on Apr 28, 2022

in share/examples/bitcoin.conf:159 in d800211404

 155 | @@ -156,6 +156,10 @@
 156 |  # Maintain coinstats index used by the gettxoutsetinfo RPC (default: 0).
 157 |  #coinstatsindex=1
 158 |  
 159 | +# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure

jonatack commented at 4:53 PM on April 29, 2022:

If you are still maintaining this proposal, you would need to remove the trailing space here for the CI linter task to pass. You can verify your change locally by running test/lint/lint-whitespace.py.
Maybe can be shortened and state the default, similar to the existing coinstats entry:

-# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure 
-# call (RPC) method `getrawtransaction` or the RESTful API call `get-tx`.
+# Maintain transaction index used by the getrawtransaction RPC (default: 0).
 #txindex=1

fanquake commented at 7:15 PM on May 4, 2022: member

Closing this now that #22235 has been merged.
fanquake closed this on May 4, 2022
laanwj commented at 7:16 PM on May 4, 2022: member

Closing as #22235 made it in. Please make any changes to help text in the option declarations in init.cpp etc.
DrahtBot locked this on May 4, 2023

Contributors

Labels

Update bitcoin.conf #24969

Conflicts