netgroup: Follow-up for #22910 #24976

1. 
   dergoegge commented at 1:27 PM on April 25, 2022: member

   This addresses my review comments I left on #22910.

   This has no effect on the current logic as nStartByte is only used for internal addresses which only ever add 10 whole bytes to the returned group. However to avoid future bugs, I think we should use nStartByte as offset for the last byte as well, in case we ever add a new address type that makes makes use of nStartByte and adds fractional bytes to the group.

2. [netgroup] Use nStartByte as offset for the last byte of the group

   Should we ever introduce a new address type that makes use of
   `nStartByte` and adds fractional bytes to the group, then nStartByte
   should be used as the offset for the last byte.

   e5d1831517
3. fanquake requested review from jnewbery on Apr 25, 2022
4. fanquake added the label P2P on Apr 25, 2022
5. 
   jnewbery commented at 10:02 AM on April 26, 2022: member

   Code review ACK e5d183151709ab59d2fa6fe9e0243000e8d6abbe

   Thanks!

6. fanquake requested review from mzumsande on Apr 26, 2022
7. theStack approved
8. 
   theStack commented at 1:12 PM on May 4, 2022: member

   Concept and code-review ACK e5d183151709ab59d2fa6fe9e0243000e8d6abbe

9. jnewbery approved
10. fanquake merged this on May 4, 2022
11. fanquake closed this on May 4, 2022

    ---

12. sidhujag referenced this in commit 9fdd5ac90c on May 4, 2022
13. DrahtBot locked this on May 4, 2023

Review Requested
mzumsande