guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported

fanquake commented at 3:30 pm on April 27, 2022: member

Our minimum supported kernel version is currently defined by Guix, as the version passed to the --enable-kernel= option when configuring glibc. That version is currently set to 3.2.0:

0            ;; This is the default for most architectures as of GNU libc 2.26,
1            ;; but we specify it explicitly for clarity and consistency.  See
2            ;; "kernel-features.h" in the GNU libc for details.
3            "--enable-kernel=3.2.0"

and has been that way since we started using Guix (i.e from Guix 1.3.0, with the release v22.0).

Passing --enable-kernel defines __LINUX_KERNEL_VERSION inside glibc, which is then used to determine supported features & syscall usage. For example, some defines in unix/sysv/linux/kernel-features.h, from glibc version 2.24, where glibcs default supported kernel version was still 2.6.32 (it’s more modern as of recent releases):

 0#ifndef __LINUX_KERNEL_VERSION
 1/* We assume the worst; all kernels should be supported.  */
 2# define __LINUX_KERNEL_VERSION	0
 3#endif
 4
 5/* Support for various CLOEXEC and NONBLOCK flags was added in
 6   2.6.23.  */
 7#define __ASSUME_O_CLOEXEC	1
 8
 9/* prlimit64 is available in 2.6.36.  */
10#if __LINUX_KERNEL_VERSION >= 0x020624
11# define __ASSUME_PRLIMIT64	1
12#endif

Note that because we currently specify the 5.15 headers, the exact version being used, i.e 5.15.x, changes when we update our time-machine commit, as Guix updates all it’s header packages as new point releases become available. Currently it is 5.15.28. The changelog for the 5.15 headers is available here.

Similar to glibc, it may currently be possible to build and run bitcoind against older kernels, however, for the purposes of documenting what we support for our release binaries, I can’t see a reason to document anything other than the version that we are targeting when building the glibc used to build the release binaries.

Guix Build (on x86_64):

 022ff2d3a72d337c4eccbfa4c834a67c7c3397f225aedb71a3c636f2708964e93  guix-build-eb02713efc17/output/aarch64-linux-gnu/SHA256SUMS.part
 1e316b2d0806183e0e51a25722f48af85d145b1581f44f68b925d9f484a5aa0d3  guix-build-eb02713efc17/output/aarch64-linux-gnu/bitcoin-eb02713efc17-aarch64-linux-gnu-debug.tar.gz
 2da667d935d9331c5cbca2e0e334cd7e56202ee294553459672fa50f13f501c4d  guix-build-eb02713efc17/output/aarch64-linux-gnu/bitcoin-eb02713efc17-aarch64-linux-gnu.tar.gz
 3f44f2921f3dac2c545806dffb579137fb9eeeee15671395f6a7f817ed6213143  guix-build-eb02713efc17/output/arm-linux-gnueabihf/SHA256SUMS.part
 4101bab25ab2a6c36729cdf840264a85700cc3cfa23d3900b0bee0ac9ae637e8d  guix-build-eb02713efc17/output/arm-linux-gnueabihf/bitcoin-eb02713efc17-arm-linux-gnueabihf-debug.tar.gz
 59f7338ee42234949ef3104c6cb2b8a723d616a46d0047d833062adc92e3b6b72  guix-build-eb02713efc17/output/arm-linux-gnueabihf/bitcoin-eb02713efc17-arm-linux-gnueabihf.tar.gz
 65ca08e7b38c4dd4456145602f25b015c164c0cd0317dd2a26855dc0495605418  guix-build-eb02713efc17/output/arm64-apple-darwin/SHA256SUMS.part
 7186c9e2df4034472107964e835ee7a05777c7a0fa5e0db12b5740f18e732d7d5  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin-unsigned.dmg
 84e252c7775662777ddcb0a1b0efac6b6e71c25479d6b44b821199ae00abd18ca  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin-unsigned.tar.gz
 94360342994d54839bbf5fb4d86c6c0b0a3cbcef68b0d2c991aab6e81301638e7  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin.tar.gz
10f354822050cd625de7445cfa317475cfad90a7e39d135c5b99950ee69969f445  guix-build-eb02713efc17/output/dist-archive/bitcoin-eb02713efc17.tar.gz
11aa864574dd692bb40df95e17c08113f5bcd04b7d5997a2f74ca0557cae3edfcd  guix-build-eb02713efc17/output/powerpc64-linux-gnu/SHA256SUMS.part
1245df2a4ec5592834fd08d36068cd0968de281870cb9df48cc4783078b85985dd  guix-build-eb02713efc17/output/powerpc64-linux-gnu/bitcoin-eb02713efc17-powerpc64-linux-gnu-debug.tar.gz
132bc1c481635ac073d61f51db425576a42a54b16218a00e5f80579426dbf9677b  guix-build-eb02713efc17/output/powerpc64-linux-gnu/bitcoin-eb02713efc17-powerpc64-linux-gnu.tar.gz
14403d7790e611d3e07b25e02549c9f50e51fff2e1a323605db4f9a569712771a7  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/SHA256SUMS.part
15db40032c3b25d95012496f1b3fa5df7f207dcbeefa510bd140b96df4dfd84c88  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/bitcoin-eb02713efc17-powerpc64le-linux-gnu-debug.tar.gz
16eea8b4ee96dc8a9813b727550bf07202a6f9cba99605247813beb5251c7f2623  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/bitcoin-eb02713efc17-powerpc64le-linux-gnu.tar.gz
177164e539d25c300b993a620caacdcef659bb6a7c4775a873e30ee645c9ceed15  guix-build-eb02713efc17/output/riscv64-linux-gnu/SHA256SUMS.part
183ae271e6fb94e5d4e46a402508a02d659e879d222c6696e57c78530157eb39ae  guix-build-eb02713efc17/output/riscv64-linux-gnu/bitcoin-eb02713efc17-riscv64-linux-gnu-debug.tar.gz
198c37d0b790c28b692804b360605baec4371af4f080c0024ba75f06c0096a4356  guix-build-eb02713efc17/output/riscv64-linux-gnu/bitcoin-eb02713efc17-riscv64-linux-gnu.tar.gz
2051bbf04cb32b579ba5609fe3ef24e9901f8d49e3311fe9776ee1fdb644f7e0b1  guix-build-eb02713efc17/output/x86_64-apple-darwin/SHA256SUMS.part
218e81f8badb0cff1aa430a899065cf9744b4b2d45addb8e30606a2f8bf08faa26  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin-unsigned.dmg
228b4120b6d83c03dae34b0b5a189522d01c523ab005d816339fdfddf9c412ef15  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin-unsigned.tar.gz
2326e633faba4f05f51f4e0bffaa2bbbf8c2d5d134d6777c9395bf9b65af6a808c  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin.tar.gz
2416c96d1f349ca3fbf5ffb8e00d5defe1af5a14abb6f61abdbd367e9a5e99bf33  guix-build-eb02713efc17/output/x86_64-linux-gnu/SHA256SUMS.part
25faa203c9c3943c2f30ca3f4f30c3eee52e38ac9a2f15c6303b0c8ff0be146e07  guix-build-eb02713efc17/output/x86_64-linux-gnu/bitcoin-eb02713efc17-x86_64-linux-gnu-debug.tar.gz
26b5cf5154ac0e2138a4ccbc7639026d909e606b9f55c5859ae54d941eb950759b  guix-build-eb02713efc17/output/x86_64-linux-gnu/bitcoin-eb02713efc17-x86_64-linux-gnu.tar.gz
27bc14a09399ef3a6d9696116ddda6509b6cb1726719dfd462106cb9d2fde32efc  guix-build-eb02713efc17/output/x86_64-w64-mingw32/SHA256SUMS.part
287c0a773f0e892e41fe8f7b299be655e53f110a64bd6e77c2e7a6b4c699605498  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-debug.zip
2927f6a50394c61c0efa2f3afe655a265c64a34249041ef0090f9043cd4cdc8c71  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-setup-unsigned.exe
30dd5bb661a9d99bbc2c2c7256996b26bef116b2e61b7497ada26b3322550d53cb  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-unsigned.tar.gz
3184d5068dd59180498473263d757192a422859c0704a2e45a762d1635e49efb80  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64.zip

Guix build (on arm64):

 02bbcf455381d4be6bb402c705dba5655de3e1b62a0ed1dbbfcb573450a63d148  guix-build-eb02713efc17/output/arm-linux-gnueabihf/SHA256SUMS.part
 1c9d982eb6c9efc752fffb3a1d2b14e8cc4d9e2cf4c03c2f02eb320d04f52a86d  guix-build-eb02713efc17/output/arm-linux-gnueabihf/bitcoin-eb02713efc17-arm-linux-gnueabihf-debug.tar.gz
 20c0b3122dcdc051bee1022dc9b0cf7771b7f6b30fa3e7369c97907d8c10d7ea3  guix-build-eb02713efc17/output/arm-linux-gnueabihf/bitcoin-eb02713efc17-arm-linux-gnueabihf.tar.gz
 35388f8a7525ed49d11569988e598a0ec68ddcaf9b35cff0c8bcb02187b0fbaad  guix-build-eb02713efc17/output/arm64-apple-darwin/SHA256SUMS.part
 416b745e2b2e036d65b549be740116d9b6e819730cc76075f01bdbc4beb166724  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin-unsigned.dmg
 518eaede02d12dcbb83003272b5b79a08a10067a326542687ab445bfc623ce9e8  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin-unsigned.tar.gz
 65fb73968c7ea50c9642d3cddcd745a512be3043ada314b8a1fc94f179744a1d8  guix-build-eb02713efc17/output/arm64-apple-darwin/bitcoin-eb02713efc17-arm64-apple-darwin.tar.gz
 7f354822050cd625de7445cfa317475cfad90a7e39d135c5b99950ee69969f445  guix-build-eb02713efc17/output/dist-archive/bitcoin-eb02713efc17.tar.gz
 8fad672b9e5d372ba5511c14ed48ef77bcf303d475f35680bd4a668fee150225a  guix-build-eb02713efc17/output/powerpc64-linux-gnu/SHA256SUMS.part
 9246aa854e87675a0b90cc14f7b6affcfefabfc0f79edd3dc96ae6b98010b8b1c  guix-build-eb02713efc17/output/powerpc64-linux-gnu/bitcoin-eb02713efc17-powerpc64-linux-gnu-debug.tar.gz
1090e968e0bab84e80a9f2fe9498eea7c59d8908f5a16accd93d7f9318a7098ce0  guix-build-eb02713efc17/output/powerpc64-linux-gnu/bitcoin-eb02713efc17-powerpc64-linux-gnu.tar.gz
1165f0c018d882d7fc845a9bb1581824b17e7ecf0df7081ab2538f0e617e120a8b  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/SHA256SUMS.part
120bf7fcd127180e5e04112914747496db535226bf05126690f259fa0cf2a96642  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/bitcoin-eb02713efc17-powerpc64le-linux-gnu-debug.tar.gz
1314fc3e17dfa903f83e44f970c8b4e4726e7476c59d0fffdec815a1c80ec1b51a  guix-build-eb02713efc17/output/powerpc64le-linux-gnu/bitcoin-eb02713efc17-powerpc64le-linux-gnu.tar.gz
149018f95b54d0643d734260b6eb69ee5f086c98e62f25dd579675b467a844793d  guix-build-eb02713efc17/output/riscv64-linux-gnu/SHA256SUMS.part
15e1f2b3678c22103d7b89cbbeec9b2863c9c6f749ff4cbedd74cb6e62598c0a04  guix-build-eb02713efc17/output/riscv64-linux-gnu/bitcoin-eb02713efc17-riscv64-linux-gnu-debug.tar.gz
16bf9fa35119344dfc93048196dd9cd5bb230b0785350ae5150bb4bdb28fd8423d  guix-build-eb02713efc17/output/riscv64-linux-gnu/bitcoin-eb02713efc17-riscv64-linux-gnu.tar.gz
1751bbf04cb32b579ba5609fe3ef24e9901f8d49e3311fe9776ee1fdb644f7e0b1  guix-build-eb02713efc17/output/x86_64-apple-darwin/SHA256SUMS.part
188e81f8badb0cff1aa430a899065cf9744b4b2d45addb8e30606a2f8bf08faa26  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin-unsigned.dmg
198b4120b6d83c03dae34b0b5a189522d01c523ab005d816339fdfddf9c412ef15  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin-unsigned.tar.gz
2026e633faba4f05f51f4e0bffaa2bbbf8c2d5d134d6777c9395bf9b65af6a808c  guix-build-eb02713efc17/output/x86_64-apple-darwin/bitcoin-eb02713efc17-x86_64-apple-darwin.tar.gz
216e5828e2efa4e951b147b8de42f79dee1652933e04c50093bd31ee375c0c4ca9  guix-build-eb02713efc17/output/x86_64-linux-gnu/SHA256SUMS.part
223d3af1d078eee6f66aac2af891fd7d7a77abc3d7164a807d0a7cc44f15e52b9d  guix-build-eb02713efc17/output/x86_64-linux-gnu/bitcoin-eb02713efc17-x86_64-linux-gnu-debug.tar.gz
2313f452bc65194de16fa91ed87be9790ed0d1a178deefb102fa54d3f9832b8c25  guix-build-eb02713efc17/output/x86_64-linux-gnu/bitcoin-eb02713efc17-x86_64-linux-gnu.tar.gz
241673b5fca6687ea0f196a5f2ce2b79662b3efe01b71f341fc596069a1ade610c  guix-build-eb02713efc17/output/x86_64-w64-mingw32/SHA256SUMS.part
25d6228bdfb4fbc7b895ed4f0c30e1343c3392bd6e8e5ed33a973887ba0bb749ba  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-debug.zip
2627f6a50394c61c0efa2f3afe655a265c64a34249041ef0090f9043cd4cdc8c71  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-setup-unsigned.exe
27dd5bb661a9d99bbc2c2c7256996b26bef116b2e61b7497ada26b3322550d53cb  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64-unsigned.tar.gz
2850a68d3644dbe5cb5de21993cd0e8992ab9c6aa88c009a75e5d5a55180476ea6  guix-build-eb02713efc17/output/x86_64-w64-mingw32/bitcoin-eb02713efc17-win64.zip

fanquake added the label Build system on Apr 27, 2022

fanquake added the label DrahtBot Guix build requested on Apr 27, 2022

hebasto commented at 3:35 pm on April 27, 2022: member

Curios, what is kernel version on supported distros?

fanquake commented at 3:50 pm on April 27, 2022: member

Curios, what is kernel version on supported distros?

Ubuntu 18.04 LTS shipped with 4.15.

laanwj commented at 8:40 am on April 28, 2022: member

Concept ACK.

FWIW: the kernel version built against does not determine the minimum supported kernel version. That’s not how it works with kernels. The functionality actually used (and required) determines the minimum kernel version. Apart from custom syscall usage this is entirely determined by glibc. Because of optional features (syscall sandboxing, etc) it’s often recommended to build against the newest kernel headers possible. 4.19 is fine, newer would be fine with me too.

guix: consolidate kernel headers to 5.15

Given no reason to use an older version of the kernel headers for the
non-RISCV linux builds, consolidate all Linux builds to 5.15.x.

Note that using older kernel headers isn't some sort of compatibility
"hack", and glibc explicitly recommends against doing so. See:
https://sourceware.org/glibc/wiki/FAQ#What_version_of_the_Linux_kernel_headers_should_be_used.3F.

dcad5f70f1

doc: add minimum required kernel version to dependencies.md

This matches the version of the kernel targeted when we build the glibcs
we use for release builds in Guix. Other versions / scenerios may
work, but for documentation purposes, this is the version that makes
sense to document, and something we can claim to officially support.

eb02713efc

fanquake force-pushed on Apr 28, 2022

fanquake commented at 9:00 am on April 28, 2022: member

Because of optional features (syscall sandboxing, etc) it’s often recommended to build against the newest kernel headers possible. 4.19 is fine, newer would be fine with me too.

Also fine with me. I’ve moved to using the 5.15.x headers, which is the most recent long term release branch.

laanwj commented at 9:35 am on April 28, 2022: member

ACK eb02713efc1751e2c4b60f72f5b407e2bc35af34

I think specifying a minimum Linux kernel in the documentation makes sense, it’s not really important right now yet because the distribution binaries link glibc dynamically (which does the actual interfacing with the kernel). But after switching to static linking (#23203) this will become more of an issue so we do need clarity around this.

fanquake renamed this:
~~guix: consolidate kernel headers to 4.19, specify 3.2.0 as minimum supported~~
guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported
on Apr 28, 2022

dongcarl commented at 3:12 pm on April 28, 2022: member

Code Review ACK eb02713efc1751e2c4b60f72f5b407e2bc35af34

FWIW: the kernel version built against does not determine the minimum supported kernel version. That’s not how it works with kernels. The functionality actually used (and required) determines the minimum kernel version. Apart from custom syscall usage this is entirely determined by glibc.

Huh! Good to know!

luke-jr commented at 3:37 pm on April 28, 2022: member

FWIW: the kernel version built against does not determine the minimum supported kernel version.

Actually, it does for Boost. :(

laanwj commented at 5:39 pm on April 28, 2022: member

Actually, it does for Boost. :(

That’s crazy. Which part?

sipa commented at 5:43 pm on April 28, 2022: member

Boost filesystem uses statx() if provided by the available kernel headers, making the build incompatible with kernels at runtime that don’t have that call. Here the author/maintainer seems to treat that as not a valid use-case: https://github.com/boostorg/filesystem/issues/172

It appears that since Boost 1.77 there is an explicit way to disable statx() support, though, and also falls back at runtime to stat() if statx isn’t available.

We don’t use boost filesystem anymore, so that’s not actually a concern - but perhaps other parts of boost have a similar mentality around kernel dependencies? It seems that different boost modules can have pretty distinct policies, though.

laanwj commented at 6:04 pm on April 28, 2022: member

Thanks. As if we’d needed another good reason to move away from boost.

I would hope that none of the parts of boost we use that are left directly use kernel system calls. They are all “pure” functionality manipulating data structures?

Oh except from boost::process.

vincenzopalazzo approved

vincenzopalazzo commented at 6:40 pm on April 28, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/25006/commits/eb02713efc1751e2c4b60f72f5b407e2bc35af34

luke-jr commented at 8:03 pm on April 28, 2022: member

(I’m not saying don’t do the bump, just that someone should check if Boost is going to mess up with this)

laanwj commented at 8:06 pm on April 28, 2022: member

No matter what gets decided, it would make sense to run the tests with the oldest kernel supported. Not sure this is possible in the CI, at least in a container setup this is not possible to reproduce as they all share the same kernel.

vincenzopalazzo commented at 8:20 pm on April 28, 2022: none

Not sure this is possible in the CI, at least in a container setup this is not possible to reproduce as they all share the same kernel.

A possible solution could be to speed up a docker and make the configuration inside it. It is a little bit messy but should work

fanquake commented at 3:44 pm on May 5, 2022: member

(I’m not saying don’t do the bump, just that someone should check if Boost is going to mess up with this)

I’ve had a look, and couldn’t see any particular reason that Boost would “mess up” with this change. If you have a particular concern / think there is something specific that needs following up on, please open an issue, and I’ll take another look.

No matter what gets decided, it would make sense to run the tests with the oldest kernel supported. Not sure this is possible in the CI, at least in a container setup this is not possible to reproduce as they all share the same kernel.

I’ll follow up with how we should do this.

fanquake merged this on May 5, 2022

fanquake closed this on May 5, 2022

fanquake deleted the branch on May 5, 2022

sidhujag referenced this in commit c52acb3c55 on May 5, 2022

MarcoFalke removed the label DrahtBot Guix build requested on May 9, 2022

dekm referenced this in commit a72d78312a on Oct 27, 2022

DrahtBot locked this on May 9, 2023

guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported #25006