test: Remove boost::split from getarg_tests.cpp #25027

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-boost-split-less-🚔 changing 1 files +3 −3
  1. MarcoFalke commented at 12:36 PM on April 29, 2022: member

    Only single spaces are used, so no need for boost.

    Can be tested with:

    diff --git a/src/test/getarg_tests.cpp b/src/test/getarg_tests.cpp
    index c877105fe7..a834830490 100644
    --- a/src/test/getarg_tests.cpp
    +++ b/src/test/getarg_tests.cpp
    @@ -21,8 +21,11 @@ BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
     void ResetArgs(ArgsManager& local_args, const std::string& strArg)
     {
         std::vector<std::string> vecArg;
    -    if (strArg.size())
    +    if (strArg.size()) {
             boost::split(vecArg, strArg, IsSpace, boost::token_compress_on);
    +        auto vecArg2{SplitString(strArg, ' ')};
    +        assert(vecArg2 == vecArg);
    +    }
     
         // Insert dummy executable name:
         vecArg.insert(vecArg.begin(), "testbitcoin");
    
  2. test: Remove boost::split from getarg_tests.cpp fafa727612
  3. fanquake approved
  4. fanquake commented at 1:18 PM on April 29, 2022: member

    utACK fafa7276126d21d7e2f723673b64382e16a902d9 - After this, the last usage of <boost/algorithm/string.hpp> is in httprpc.cpp.

  5. DrahtBot added the label Tests on Apr 29, 2022
  6. fanquake merged this on Apr 30, 2022
  7. fanquake closed this on Apr 30, 2022

  8. MarcoFalke deleted the branch on Apr 30, 2022
  9. sidhujag referenced this in commit 43a6ef71ce on Apr 30, 2022
  10. kittywhiskers referenced this in commit e5d00d0c95 on Dec 21, 2022
  11. kittywhiskers referenced this in commit 383d242465 on Dec 26, 2022
  12. kittywhiskers referenced this in commit f36e54a225 on Jan 3, 2023
  13. kittywhiskers referenced this in commit 86653a6d29 on Jan 13, 2023
  14. kittywhiskers referenced this in commit 6e521e9417 on Jan 15, 2023
  15. kittywhiskers referenced this in commit 5cca21d73c on Jan 19, 2023
  16. PastaPastaPasta referenced this in commit 2d7a448fdc on Jan 19, 2023
  17. DrahtBot locked this on Apr 30, 2023
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me