ci: Clone iwyu only if missing #25028

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-iwyu-clone-📤 changing 2 files +8 −5

MarcoFalke commented at 12:50 PM on April 29, 2022: member

This doesn't change anything for Cirrus CI, but makes it easier to play locally.

For reference, the same check is done when cloning DIR_FUZZ_IN.
fanquake approved
fanquake commented at 1:51 PM on April 29, 2022: member

utACK fac6a7df5553050890469cf307667150d846e369
DrahtBot added the label Tests on Apr 29, 2022
ci: Clone iwyu only if missing fa847ed2f6

in ci/test/04_install.sh:115 in fac6a7df55 outdated

 111 | @@ -112,10 +112,13 @@ if [[ ${USE_MEMORY_SANITIZER} == "true" ]]; then
 112 |  fi
 113 |  
 114 |  if [[ "${RUN_TIDY}" == "true" ]]; then
 115 | -  CI_EXEC "mkdir -p ${BASE_SCRATCH_DIR}/iwyu/build/"
 116 | -  CI_EXEC "git clone --depth=1 https://github.com/include-what-you-use/include-what-you-use -b clang_14 ${BASE_SCRATCH_DIR}/iwyu/include-what-you-use"
 117 | -  CI_EXEC "cd ${BASE_SCRATCH_DIR}/iwyu/build && cmake -G 'Unix Makefiles' -DCMAKE_PREFIX_PATH=/usr/lib/llvm-14 ../include-what-you-use"
 118 | -  CI_EXEC "cd ${BASE_SCRATCH_DIR}/iwyu/build && make install $MAKEJOBS"
 119 | +  export DIR_IWYU="${BASE_SCRATCH_DIR}/iwyu/"

jonatack commented at 7:33 PM on April 29, 2022:

Not sure, but it looks like a / should either be dropped here, or dropped in the other lines that use it.

  export DIR_IWYU="${BASE_SCRATCH_DIR}/iwyu"

MarcoFalke commented at 7:24 AM on April 30, 2022:

thx changed. I don't think it makes a difference, though.

MarcoFalke force-pushed on Apr 30, 2022
fanquake approved
fanquake commented at 8:57 AM on April 30, 2022: member

ACK fa847ed2f698a8a999352aeed63baf60b094e662
fanquake merged this on Apr 30, 2022
fanquake closed this on Apr 30, 2022
MarcoFalke deleted the branch on Apr 30, 2022
sidhujag referenced this in commit fcc147e8ac on Apr 30, 2022
DrahtBot locked this on Apr 30, 2023

Contributors

Labels