The mac binary should contain proper version information.
mac binary has unusual version (meta) information #2506
issue jonasschnelli opened this issue on April 11, 2013-
jonasschnelli commented at 8:52 AM on April 11, 2013: contributor
-
jonasschnelli commented at 8:53 AM on April 11, 2013: contributor
who or what does the mac release build?
-
laanwj commented at 9:14 AM on April 11, 2013: member
Gavin does.
-
jonasschnelli commented at 9:40 AM on April 11, 2013: contributor
i'll check the std build process and see if i can write a fix for the version meta information on the mac binary. Even when build with Qt Creator the version meta info is somehow unusable.
-
Diapolo commented at 11:41 AM on April 11, 2013: none
I fixed the same stuff for Windows a few months ago :). Correct meta information is a good thing IMHO.
-
jonasschnelli commented at 9:07 PM on April 14, 2013: contributor
@gavinandresen can you check (if time), if the description for mac release still are valid:
https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.txt#L76-83
-
gavinandresen commented at 11:11 PM on April 14, 2013: contributor
RE: release-process: yes, that is the process.
Does the version meta information come from the share/qt/Info.plist file?
-
jonasschnelli commented at 5:22 AM on April 15, 2013: contributor
@gavinandresen the version information can be placed there. But QT only support the @SHORT_VERSION@ which then would be 0.8 (for 0.8.2) which is somehow not funny. But the Info.plist has currently no affect because of a (still open) QT Bug (https://bugreports.qt-project.org/browse/QTBUG-21267). That's why the current binary release also have strange infos. But i have a fix (on the way).
- jonasschnelli referenced this in commit f95279ba79 on Apr 15, 2013
- gavinandresen closed this on May 7, 2013
- gavinandresen referenced this in commit 7aaaff37ff on May 7, 2013
- kyledrake referenced this in commit 6baa4992ee on Jul 25, 2013
- laudney referenced this in commit de48439d3a on Mar 19, 2014
- laudney referenced this in commit 20d99aa3c5 on Mar 19, 2014
- MarcoFalke locked this on Sep 8, 2021
