fixes #2506: mac binary with proper version and copyright meta-informati... #2532

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:mac_plist_fix changing 3 files +35 −1
  1. jonasschnelli commented at 2:16 PM on April 15, 2013: contributor

    ...ons (Info.plist)

    Due a bug in QT (https://bugreports.qt-project.org/browse/QTBUG-21267), the mac binary of the last release contains bulk meta informations.

    The url-handler (bitcoin://) is also not working in current release

    Should be fixed with this commit.

    see #2506

  2. fixes #2506: mac binary with proper version and copyright meta-informations (Info.plist)
    Due a bug in QT (https://bugreports.qt-project.org/browse/QTBUG-21267), the mac binary of the last release contains bulk meta informations.
    
    The url-handler (bitcoin://) is also not working in current release
    
    Should be fixed with this commit.
    
    Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
    f95279ba79
  3. jonasschnelli commented at 2:17 PM on April 15, 2013: contributor

    Should then look like: Bildschirmfoto 2013-04-15 um 16 00 36

  4. in doc/release-process.txt:None in f95279ba79
      79 | @@ -80,6 +80,7 @@
      80 |    make
      81 |    export QTDIR=/opt/local/share/qt4  # needed to find translations/qt_*.qm files
      82 |    T=$(contrib/qt_translations.py $QTDIR/translations src/qt/locale)
      83 | +  python2.7 share/qt/clean_mac_info_plist.py
    


    jonasschnelli commented at 2:18 PM on April 15, 2013:

    a new script must be called before packaging (fancy dmg) and before code sign.

  5. gavinandresen commented at 12:41 AM on April 16, 2013: contributor

    pull-tester failure looks like a false-positive; the unit test failing is one I wrote, that tries to test some multi-threading stuff; I've had trouble with them occasionally running on a heavily-loaded machine.

  6. laanwj commented at 2:55 PM on April 18, 2013: member

    Can anyone on Mac test this please?

  7. gavinandresen commented at 3:37 PM on May 7, 2013: contributor

    Works nicely.

  8. gavinandresen referenced this in commit 7aaaff37ff on May 7, 2013
  9. gavinandresen merged this on May 7, 2013
  10. gavinandresen closed this on May 7, 2013

  11. laudney referenced this in commit 20d99aa3c5 on Mar 19, 2014
  12. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 12:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me