test: Remove extended lint (cppcheck) #25091

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2022-05-remove-extended-lints changing 2 files +0 −114
  1. laanwj commented at 1:01 PM on May 9, 2022: member

    These are unreferenced in the CI and documentation, and have been since 2019 (see #17549).

    I'm not sure the cppcheck is worthwhile. It takes a long time to run (I think this is why it isn't in the normal lints), and right now it only appears to find implicit constructors. The list of exceptions is out of date. But if anyone wants to bring it back at any time in the future they can do so from git history (and port it to Python).

  2. test: Remove extended lint (cppcheck)
    These are unreferenced in the CI and documentation, and have been since
    2019 (see #17549).
    
    I'm not sure the cppcheck is worthwhile. It takes a long time
    to run (I think this is why it isn't in the normal lints), and right
    now it only appears to find implicit constructors. The list of
    exceptions is out of date. But if anyone wants to bring it back at any
    time in the future they can do so from git history (and port it to Python).
    efae252f30
  3. laanwj added the label Tests on May 9, 2022
  4. fanquake approved
  5. fanquake commented at 1:05 PM on May 9, 2022: member

    ACK efae252f3072da598160670691757a0d60b9beb4

  6. MarcoFalke merged this on May 9, 2022
  7. MarcoFalke closed this on May 9, 2022

  8. MarcoFalke commented at 1:11 PM on May 9, 2022: member

    Also, it would be better if this was using the compile db instead of the ls-files | xargs approach

  9. sidhujag referenced this in commit 45f774afb7 on May 9, 2022
  10. DrahtBot locked this on May 9, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me