Fixed width integer types prefixed with u_int are not part of C++ (see https://en.cppreference.com/w/cpp/types/integer), so it's better to avoid and replace them with their standard-conforming counterparts. (For those interested in history, according to one theory those u_int... types have been introduced by BSD: https://stackoverflow.com/a/5163960, http://lists.freedesktop.org/archives/release-wranglers/2004-August/000923.html).
scripted-diff: replace non-standard fixed width integer types (`u_int`... -> `uint`...) #25115
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202205-refactor-replace_non_std_fixed_width_integer_types changing 3 files +7 −7-
theStack commented at 1:58 PM on May 12, 2022: member
-
672d49c863
scripted-diff: replace non-standard fixed width integer types (`u_int`...` -> `uint`...)
-BEGIN VERIFY SCRIPT- sed -i 's/u_int/uint/g' $(git grep -l u_int) -END VERIFY SCRIPT-
-
laanwj commented at 2:22 PM on May 12, 2022: member
I'd never even heard of these!
Code review ACK 672d49c863fd6b0f096f166aeb3504f51dfa7d19
- laanwj added the label Refactoring on May 12, 2022
- fanquake approved
-
fanquake commented at 8:07 PM on May 12, 2022: member
ACK 672d49c863fd6b0f096f166aeb3504f51dfa7d19
- fanquake merged this on May 12, 2022
- fanquake closed this on May 12, 2022
- theStack deleted the branch on May 12, 2022
-
jonatack commented at 8:30 PM on May 12, 2022: member
Post-merge review ACK.
- sidhujag referenced this in commit 468cdc24a9 on May 13, 2022
- Fabcien referenced this in commit 4b5fdf3dc6 on Mar 6, 2023
- DrahtBot locked this on May 12, 2023
Labels