qt: move export button to tabs #2515

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_04_move_exportbutton changing 6 files +31 −30

laanwj commented at 10:28 AM on April 12, 2013: member

Having the export button at the top was confusing people into thinking the entire wallet was exported.

This commit moves the export button to the address book, receiving addresses and transaction tabs separately.
BitcoinPullTester commented at 10:49 AM on April 12, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/761085146ab48f1f238fa876791efc23d9318dac for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (you can find the patches applied at test-time at http://jenkins.bluematt.me/pull-tester/files/patches/)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

qt: move export button to tabs

Having the export button at the top was confusing people into thinking
the entire wallet was exported.

This commit moves the export button to the address book, receiving
addresses and transaction tabs separately.

45155d3010

in src/qt/forms/addressbookpage.ui:None in 761085146a outdated
```
   5 | @@ -6,7 +6,7 @@
   6 |     <rect>
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 | -    <width>760</width>
  10 | +    <width>982</width>
```
Diapolo commented at 11:07 AM on April 12, 2013:

Was that big resize intended?

laanwj commented at 11:12 AM on April 12, 2013:

No, Qt designer is kind of annoying in that...

in src/qt/addressbookpage.h:None in 761085146a outdated

  84 | @@ -84,6 +85,7 @@ class AddressBookPage : public QDialog
  85 |      /** New entry/entries were added to address table */
  86 |      void selectNewAddress(const QModelIndex &parent, int begin, int /*end*/);
  87 |  
  88 | +

Diapolo commented at 11:09 AM on April 12, 2013:

? :-P

laanwj commented at 11:19 AM on April 12, 2013: member

@diapolo both fixed

laanwj commented at 11:39 AM on April 12, 2013: member

Hmm this doesn't seem to be caused by my changes:

+ LD_PRELOAD=/usr/lib/jvm/java-6-openjdk/jre/lib/i386/jli/libjli.so java -Xmx5G -jar /mnt/test-scripts/BitcoinjBitcoindComparisonTool.jar 8333
Invalid maximum heap size: -Xmx5G
The specified size exceeds the maximum representable size.
Could not create the Java virtual machine.

TheBlueMatt commented at 4:32 PM on April 12, 2013: member

Indeed, false negative...sorry, Ive reset this pull so it should come back with a new test
BitcoinPullTester commented at 4:57 PM on April 12, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/45155d3010a3bbbe3cfbba670538ae18b9772a39 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 8:08 PM on April 12, 2013: member

Sounds like a good idea.
Diapolo commented at 11:08 PM on April 12, 2013: none

Code looks good, but haven't tested.
laanwj referenced this in commit f81b67829d on Apr 13, 2013
laanwj merged this on Apr 13, 2013
laanwj closed this on Apr 13, 2013
laudney referenced this in commit 652156ec3f on Mar 19, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors