doc: remove passing `--disable-external-signer` in OpenBSD build guide #25178

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202205-doc-update_openbsd_build_docs_71 changing 1 files +6 −9

theStack commented at 1:55 PM on May 20, 2022: member
Since we have a Boost.Process usage check in the build system (#24254, commit abc057c6030b2a0ddab46835a7801054da677781), passing the option --disable-external-signer explicitly is not needed anymore on OpenBSD; the configure script will automatically detect that including <boost/process.hpp> leads to a compile error and disable external signer support accordingly:
```
$ ./configure MAKE=gmake
...
checking whether Boost.Process can be used... no
...
Options used to compile and link:
  external signer = no
...

$ ./configure --enable-external-signer MAKE=gmake
...
checking whether Boost.Process can be used... no
configure: error: External signing is not supported for this Boost version
```
The PR basically reverts #22335 but keeps the part mentioning that external signer support is not available on OpenBSD. Also bumps the guide to version 7.1 (released about a month ago), where I could verify that the instructions are still accurate.

doc: remove passing `--disable-external-signer` in OpenBSD build guide

Since the Boost.Process usage check was added to the build system
(commit abc057c6030b2a0ddab46835a7801054da677781), passing the option
`--disable-external-signer` explicitly is not needed anymore on OpenBSD;
The configure script will automatically detect that including
<boost/process.hpp> leads to a compile error and disable external signer
support accordingly.

9ecb0a3550

fanquake added the label Docs on May 20, 2022
fanquake approved
fanquake commented at 6:38 AM on May 23, 2022: member

ACK 9ecb0a355099c0126c9c8193c7597c73f73428ad
fanquake merged this on May 23, 2022
fanquake closed this on May 23, 2022
theStack deleted the branch on May 23, 2022
sidhujag referenced this in commit 4f9f3e92f7 on May 28, 2022
DrahtBot locked this on May 23, 2023

Contributors

theStack

fanquake

Labels

Docs

Linked (view graph)

#22335 doc: recommend `--disable-external-signer` in OpenBSD build guide #24254 build: Add Boost.Process usage check