refactor: Remove defunct attributes.h includes #25184

pull Empact wants to merge 1 commits into bitcoin:master from Empact:2022-05-attributes-include changing 16 files +2 −14

Empact commented at 6:58 PM on May 21, 2022: member
Since the removal of NODISCARD in 81d5af42f4dba5b68a597536cad7f61894dc22a3, the only attributes.h def is LIFETIMEBOUND, and it's included in many more places that it is used.

This removes all includes which do not have an associated use of LIFETIMEBOUND, and adds it to the following files, due to their use of the same:
- src/validationinterface.h
- src/script/standard.h
See also #20499.

refactor: Remove defunct attributes.h includes

Since the removal of NODISCARD in 81d5af42f4dba5b68a597536cad7f61894dc22a3,
the only attributes def is LIFETIMEBOUND, and it's included in many more
places that it is used.

This removes all includes which do not have an associated use of LIFETIMEBOUND,
and adds it to the following files, due to their use of the same:
* src/validationinterface.h
* src/script/standard.h

71a8dbe5da

DrahtBot added the label Refactoring on May 21, 2022
MarcoFalke commented at 7:40 AM on May 23, 2022: member

Seems ok, but in the future it would be good to use iwyu for this. See also #25067 (review)
MarcoFalke merged this on May 23, 2022
MarcoFalke closed this on May 23, 2022
sidhujag referenced this in commit ec3c4daa31 on May 28, 2022
Fabcien referenced this in commit 40a17fb3a8 on Mar 10, 2023
DrahtBot locked this on May 23, 2023

Contributors

Empact

MarcoFalke

Labels

Refactoring

Linked (view graph)

#20499 Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17).