doc: Fix spelling errors identified by codespell in comments #25200

pull Empact wants to merge 2 commits into bitcoin:master from Empact:2022-05-codespell changing 5 files +7 −6
  1. Empact commented at 2:51 PM on May 24, 2022: member

    From the output here:

    src/qt/test/addressbooktests.cpp:185: wilcard ==> wildcard
    src/qt/test/addressbooktests.cpp:191: wilcard ==> wildcard
    src/test/miniscript_tests.cpp:227: nd ==> and, 2nd
    src/test/versionbits_tests.cpp:260: everytime ==> every time
    src/util/time.h:89: precicion ==> precision
    src/util/time.h:90: precicion ==> precision
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
    

    I left the 'nd' in miniscript_tests as-is, as it's valid miniscript, and I'm wary of whitelisting it.

  2. jonatack commented at 3:10 PM on May 24, 2022: member

    A couple more minor fixups that can be squashed in here, for your consideration:

    diff --git a/doc/fuzzing.md b/doc/fuzzing.md
    index 9abfbc9213..7a2191f859 100644
    --- a/doc/fuzzing.md
    +++ b/doc/fuzzing.md
    @@ -105,7 +105,7 @@ Fuzzing on a harness compiled with `--with-sanitizers=address,fuzzer,undefined` 
     ## Reproduce a fuzzer crash reported by the CI
     
    -- `cd` into the `qa-assets` directory and update it with `git pull qa-assets`
    +- `cd` into the `qa-assets` directory and update it with `git pull`
    diff --git a/src/bench/bench.cpp b/src/bench/bench.cpp
    index d26b52410c..26975bb59d 100644
    --- a/src/bench/bench.cpp
    +++ b/src/bench/bench.cpp
    @@ -58,7 +58,7 @@ void benchmark::BenchRunner::RunAll(const Args& args)
         if (args.sanity_check) {
    -        std::cout << "Running with --sanity check option, benchmark results will be useless." << std::endl;
    +        std::cout << "Running with --sanity-check option, benchmark results will be useless." << std::endl;
    

    Seems ok to add "nd" to test/lint/spelling.ignore-words.txt.

  3. DrahtBot added the label Refactoring on May 24, 2022
  4. DrahtBot commented at 3:54 AM on May 25, 2022: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24798 ([POC] build: Hello Qt 6 by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. doc: Fix spelling errors identified by codespell in coments
    From the output here:
    src/qt/test/addressbooktests.cpp:185: wilcard ==> wildcard
    src/qt/test/addressbooktests.cpp:191: wilcard ==> wildcard
    src/test/miniscript_tests.cpp:227: nd ==> and, 2nd
    src/test/versionbits_tests.cpp:260: everytime ==> every time
    src/util/time.h:89: precicion ==> precision
    src/util/time.h:90: precicion ==> precision
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
    https://cirrus-ci.com/task/5275612980969472?logs=lint#L849
    
    I added 'nd' to the spelling.ignored-words.txt, as it's valid miniscript.
    bf209ac7a7
  6. Fixup option name in bench message f565b2836d
  7. Empact force-pushed on May 25, 2022
  8. Empact commented at 5:28 AM on May 25, 2022: member

    @jonatack picked up the latter fixup, added nd to the ignore list.

  9. dunxen approved
  10. dunxen commented at 1:09 PM on May 31, 2022: contributor

    ACK f565b28

    Meta nit: Spelling in commit message/PR title :smile: : s/coments/comments

  11. MarcoFalke renamed this:
    doc: Fix spelling errors identified by codespell in coments
    doc: Fix spelling errors identified by codespell in comments
    on May 31, 2022
  12. MarcoFalke merged this on May 31, 2022
  13. MarcoFalke closed this on May 31, 2022

  14. jonatack commented at 1:45 PM on May 31, 2022: member

    ~I left the 'nd' in miniscript_tests as-is, as it's valid miniscript, and I'm wary of whitelisting it.~

    Note to contributors, strikethrough formatting in the PR description doesn't seem to translate very well in the merge commit. Probably best to just remove it.

          ~~I left the 'nd' in miniscript_tests as-is, as it's valid miniscript,
          and I'm wary of whitelisting it.~~
    
  15. sidhujag referenced this in commit 4a93d2b59f on May 31, 2022
  16. onyea commented at 2:32 AM on June 9, 2022: none

    Send to my wallet

  17. fanquake locked this on Jun 9, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me