refactor: Pass reference to LookUpStats #25222

1. 
   MarcoFalke commented at 2:59 pm on May 26, 2022: member

   I find it confusing to have an interface that accepts nullptr, but immediately crashes the program when someone does pass nullptr.

   Fix that.

   Also some include fixups.

2. MarcoFalke added the label Refactoring on May 26, 2022
3. 
   jonatack commented at 4:58 pm on May 26, 2022: contributor

   Concept ACK

   0CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.
   1src/rpc/blockchain.cpp:827:            CBlockIndex& block_index = *Assert(WITH_LOCK(::cs_main, return blockman.LookupBlockIndex(view->GetBestBlock())));
   2
   3^---- failure generated from lint-assertions.py
   

4. MarcoFalke force-pushed on May 27, 2022
5. 
   MarcoFalke commented at 1:03 pm on May 27, 2022: member

   Thx, fixed
6. 
   DrahtBot commented at 5:41 pm on June 2, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. DrahtBot added the label Needs rebase on Jul 19, 2022
8. refactor: Pass reference to LookUpStats faa3d38ec6
9. MarcoFalke force-pushed on Jul 20, 2022
10. DrahtBot removed the label Needs rebase on Jul 20, 2022
11. 
    jonatack commented at 2:52 pm on July 20, 2022: contributor

    Approach ACK, changes LGTM on first read over GitHub, checked that a lifetimebound annotation isn’t needed.
12. 
    aureleoules commented at 9:38 am on September 13, 2022: member

    ACK faa3d38ec6f2999740486c6c66cd062e74c769fb
13. fanquake requested review from dergoegge on Sep 13, 2022
14. fanquake requested review from mzumsande on Sep 13, 2022
15. MarcoFalke merged this on Sep 13, 2022
16. MarcoFalke closed this on Sep 13, 2022

    ---

17. MarcoFalke deleted the branch on Sep 13, 2022
18. sidhujag referenced this in commit 68233eaf56 on Sep 13, 2022
19. bitcoin locked this on Sep 13, 2023

Contributors
MarcoFalke jonatack DrahtBot aureleoules

Review Requested
dergoegge mzumsande

Labels
Refactoring