Get time less often in AddrManImpl::ResolveCollisions_() #25224

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2205-time-less-🐠 changing 1 files +8 −6
  1. MarcoFalke commented at 10:09 AM on May 27, 2022: member

    First commit split out from https://github.com/bitcoin/bitcoin/pull/24697

  2. Get time less often in AddrManImpl::ResolveCollisions_()
    This makes the code less verbose. Also, future changes that change how
    to get the time are less verbose.
    
    Moreover, GetAdjustedTime() might arbitrarily change the value during
    the execution of this function. For example, the system time advances
    over a second boundary, or the network adjusts the time arbitrarily.
    Most of the time however the value will not change, so it seems better
    to always lock the value in this scope for clarity.
    fa27ee88ed
  3. MarcoFalke added the label Refactoring on May 27, 2022
  4. fanquake approved
  5. fanquake commented at 1:26 PM on May 27, 2022: member

    ACK fa27ee88edbf696b7eef2efbfcf1446ec522fd85

  6. sipa commented at 4:06 PM on May 27, 2022: member

    utACK fa27ee88edbf696b7eef2efbfcf1446ec522fd85

  7. fanquake merged this on May 28, 2022
  8. fanquake closed this on May 28, 2022

  9. sidhujag referenced this in commit 617d0bd427 on May 28, 2022
  10. fanquake deleted a comment on May 29, 2022
  11. MarcoFalke deleted the branch on May 30, 2022
  12. DrahtBot locked this on May 30, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me