First commit split out from https://github.com/bitcoin/bitcoin/pull/24697
Get time less often in AddrManImpl::ResolveCollisions_() #25224
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2205-time-less-🐠 changing 1 files +8 −6-
MarcoFalke commented at 10:09 AM on May 27, 2022: member
-
fa27ee88ed
Get time less often in AddrManImpl::ResolveCollisions_()
This makes the code less verbose. Also, future changes that change how to get the time are less verbose. Moreover, GetAdjustedTime() might arbitrarily change the value during the execution of this function. For example, the system time advances over a second boundary, or the network adjusts the time arbitrarily. Most of the time however the value will not change, so it seems better to always lock the value in this scope for clarity.
- MarcoFalke added the label Refactoring on May 27, 2022
- fanquake approved
-
fanquake commented at 1:26 PM on May 27, 2022: member
ACK fa27ee88edbf696b7eef2efbfcf1446ec522fd85
-
sipa commented at 4:06 PM on May 27, 2022: member
utACK fa27ee88edbf696b7eef2efbfcf1446ec522fd85
- fanquake merged this on May 28, 2022
- fanquake closed this on May 28, 2022
- sidhujag referenced this in commit 617d0bd427 on May 28, 2022
- fanquake deleted a comment on May 29, 2022
- MarcoFalke deleted the branch on May 30, 2022
- DrahtBot locked this on May 30, 2023
Contributors
Labels