Revert "build: more robustly check for fcf-protection support" #25246

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_clang_7_note changing 1 files +1 −4

fanquake commented at 10:43 AM on May 30, 2022: member

We no-longer support Clang 7 (#24164). Introduced in #20720.

This reverts commit e9189a750b237eba1befc6b16c12c2cee3e0176c.
fanquake added the label Build system on May 30, 2022
laanwj commented at 12:48 PM on May 30, 2022: member

ACK 460854c1eba7a509327d17fd995b27d9cc8ad5f6 makes sense to revert this workaround.

in configure.ac:938 in 460854c1eb outdated

 934 | @@ -935,10 +935,7 @@ if test "$use_hardening" != "no"; then
 935 |    AX_CHECK_COMPILE_FLAG([-Wstack-protector], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -Wstack-protector"])
 936 |    AX_CHECK_COMPILE_FLAG([-fstack-protector-all], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fstack-protector-all"])
 937 |  
 938 | -  dnl -fcf-protection used with Clang 7 causes ld to emit warnings:
 939 | -  dnl ld: error: ... <corrupt x86 feature size: 0x8>
 940 | -  dnl Use CHECK_LINK_FLAG & --fatal-warnings to ensure we won't use the flag in this case.
 941 | -  AX_CHECK_LINK_FLAG([-fcf-protection=full], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fcf-protection=full"], [], [$LDFLAG_WERROR])
 942 | +  AX_CHECK_COMPILE_FLAG([-fcf-protection=full],[HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fcf-protection=full"])

hebasto commented at 1:06 PM on May 30, 2022:

style nit: Add a space after the comma?

  AX_CHECK_COMPILE_FLAG([-fcf-protection=full], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fcf-protection=full"])

fanquake commented at 5:41 AM on May 31, 2022:

sure

hebasto approved
hebasto commented at 1:07 PM on May 30, 2022: member

ACK 460854c1eba7a509327d17fd995b27d9cc8ad5f6

Revert "build: more robustly check for fcf-protection support"

We no-longer support Clang 7 (#24164).

This reverts commit e9189a750b237eba1befc6b16c12c2cee3e0176c.

a7973bf8f4

fanquake force-pushed on May 31, 2022
hebasto approved
hebasto commented at 7:29 AM on May 31, 2022: member

re-ACK a7973bf8f46a7fe1c70d33a1098da6aba66baaed
MarcoFalke merged this on May 31, 2022
MarcoFalke closed this on May 31, 2022
fanquake deleted the branch on May 31, 2022
sidhujag referenced this in commit 5c11078df9 on May 31, 2022
DrahtBot locked this on May 31, 2023

Contributors

Labels

Linked (view graph)

#20720 build: more robustly check for fcf-protection support #24164 build: Bump minimum required clang/libc++ to 8.0