Move minRelayTxFee to policy/settings #25254

1. 
   MarcoFalke commented at 1:08 pm on May 31, 2022: member

   Seems a bit confusing to put policy stuff into validation, so fix that.

   Also fix includes via iwyu.

2. Move minRelayTxFee to policy/settings

   Also fix includes using iwyu

   fa4068b4e2
3. DrahtBot added the label Refactoring on May 31, 2022
4. 
   DrahtBot commented at 10:21 am on June 1, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25290 ([kernel 3a/n] Decouple CTxMemPool from ArgsManager by dongcarl)
   • #25285 (Add AutoFile without ser-type and ser-version and use it where possible by MarcoFalke)
   • #24513 (CChainState -> Chainstate by jamesob)
   • #23076 (Pass CFeeRate and CTxMemPool in-params by reference to const by jonatack)
   • #17786 (refactor: Nuke policy/fees->mempool circular dependencies by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. in src/validation.h:62 in fa4068b4e2

   57@@ -58,8 +58,6 @@ namespace Consensus {
   58 struct Params;
   59 } // namespace Consensus
   60 
   61-/** Default for -minrelaytxfee, minimum relay fee for transactions */
   62-static const unsigned int DEFAULT_MIN_RELAY_TX_FEE = 1000;
   

   ---

   ---

   

   ariard commented at 9:45 pm on June 6, 2022:

   What do you think to move too the following default values validation.h from in policy.h ?

   • DEFAULT_ANCESTOR_LIMIT
   • DEFAULT_ANCESTOR_SIZE_LIMIT
   • DEFAULT_DESCENDANT_LIMIT
   • DEFAULT_DESCENDANT_SIZE_LIMIT
   • DEFAULT_MEMPOOL_EXPIRY

   ---

   

   MarcoFalke commented at 6:01 am on June 7, 2022:

   Happy to review a follow-up, if someone creates one.
6. ariard approved
7. 
   ariard commented at 9:46 pm on June 6, 2022: member

   ACK fa4068b, the includes move compiles well locally.
8. ryanofsky approved
9. 
   ryanofsky commented at 11:23 pm on June 6, 2022: member

   Code review ACK fa4068b4e2192f168bb120624eca5735f0dadf6f. Make sense to move the global variable to policy/settings and the default constant to policy/policy. Ariard points out other constants that could be moved, which seems fine, but it seems like moving the global variable to be with other related global variables is more significant.

   I think this variable was just forgotten in 4a75c9d6512a5580e60104103ea11d2cd9586354 from #15638 which moved other variables because it wasn’t used by wallet code

10. MarcoFalke merged this on Jun 7, 2022
11. MarcoFalke closed this on Jun 7, 2022

    ---

12. MarcoFalke deleted the branch on Jun 7, 2022
13. sidhujag referenced this in commit fee70cf02f on Jun 8, 2022
14. laanwj referenced this in commit 57a491bee1 on Jun 20, 2022
15. DrahtBot locked this on Jun 7, 2023

Contributors
MarcoFalke DrahtBot ariard ryanofsky

Labels
Refactoring