consensus: move version.h into consensus/ #25260

1. 
   fanquake commented at 1:39 pm on June 1, 2022: member

   Related to #15732.
2. fanquake added the label Refactoring on Jun 1, 2022
3. fanquake added the label Consensus on Jun 1, 2022
4. 
   MarcoFalke commented at 2:52 pm on June 1, 2022: member

   Idk. It is absurd that the p2p protocol version affects consensus. I think we should remove it with something like #19503 instead of enforcing it more.

   Also, wouldn’t this needed to be moved to kernel?

5. scripted-diff: use static constexpr in version.h

   -BEGIN VERIFY SCRIPT-
   sed -i -e "s/static const/static constexpr/" src/version.h
   -END VERIFY SCRIPT-

   e36d020597
6. consensus: move version.h into consensus/ c4416ffceb
7. fanquake force-pushed on Jun 1, 2022
8. 
   fanquake commented at 3:54 pm on June 1, 2022: member

   instead of enforcing it more.

   This just moves files to better reflect the makeup of libbitcoin_consensus; not sure it’s enforcing anything any further. If we’d rather revive something like #19503 happy to close.

   Also, wouldn’t this needed to be moved to kernel?

   Possibly, although in that case, I assume it’s consensus/ wholesale being moved under kernel/?

9. 
   laanwj commented at 7:08 am on June 2, 2022: member

   Idk. It is absurd that the p2p protocol version affects consensus. I think we should remove it with something like #19503 instead of enforcing it more.

   I have to agree here. Yes, this is more consistent, but it’s the wrong kind of consistent. I prefer not to make a huge change like this (73 files updated) for something that is conceptually a step in the wrong direction, and we definitely would want to reverse later.

10. 
    DrahtBot commented at 4:55 pm on June 2, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24994 (build: Build libbitcoinconsensus from its own convenience library by hebasto)
    • #21283 (Implement BIP 370 PSBTv2 by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    fanquake commented at 7:50 am on June 3, 2022: member

    Ok. Let’s do something different.
12. fanquake closed this on Jun 3, 2022

    ---

13. bitcoin locked this on Jun 3, 2023
14. fanquake deleted the branch on Sep 11, 2023

Contributors
fanquake MarcoFalke laanwj DrahtBot

Labels
Refactoring Consensus