build: pass minisketch cppflags only where needed #25263

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:minisketch_cpp_needed changing 2 files +4 −4

fanquake commented at 3:13 PM on June 1, 2022: member

Move minisketch cppflags out of the catch-all BITCOIN_INCLUDES and pass them only where they are needed, which is to libbitcoin_node, and the (fuzz) tests.

Similar to #25244.

build: pass minisketch cppflags only where needed

Move minisketch cppflags out of the catch-all BITCOIN_INCLUDES and pass
them only where they are needed, which is to libbitcoin_node, and the
(fuzz) tests.

8701c8b6bb

fanquake added the label Build system on Jun 1, 2022
DrahtBot commented at 1:34 AM on June 21, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

in src/Makefile.am:26 in 8701c8b6bb

  22 | @@ -23,7 +23,7 @@ noinst_PROGRAMS =
  23 |  TESTS =
  24 |  BENCHMARKS =
  25 |  
  26 | -BITCOIN_INCLUDES=-I$(builddir) -I$(srcdir)/$(MINISKETCH_INCLUDE_DIR_INT) -I$(srcdir)/secp256k1/include -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT) $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS)
  27 | +BITCOIN_INCLUDES=-I$(builddir) -I$(srcdir)/secp256k1/include -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT) $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS)

laanwj commented at 5:20 AM on June 21, 2022:

Would it make sense to define MINISKETCH_INCLUDES instead of pasting this verbatim?

fanquake closed this on Aug 8, 2022
bitcoin locked this on Aug 8, 2023
fanquake deleted the branch on Sep 11, 2023

Contributors

Labels

Linked (view graph)

#25244 build: pass bdb cppflags only where needed

build: pass minisketch cppflags only where needed #25263

Conflicts