Move DEFAULT_ANCESTOR_LIMIT to policy/settings #25295

1. 
   ghost commented at 3:18 pm on June 7, 2022: none

   This is a follow up commit from #25254 (review)

   This commit moves ancestor limit from validation to policy/settings.

2. Move DEFAULT_ANCESTOR_LIMIT to policy/settings 143ee1559b
3. unknown marked this as a draft on Jun 7, 2022
4. Move DEFAULT_ANCESTOR_LIMIT to policy/settings d8901975f0
5. Move DEFAULT_ANCESTOR_LIMIT to policy/settings 07f9d2a4cf
6. unknown marked this as ready for review on Jun 7, 2022
7. hebasto deleted a comment on Jun 7, 2022
8. laanwj added the label Mempool on Jun 7, 2022
9. in src/validation.h:61 in 07f9d2a4cf

   57@@ -58,8 +58,6 @@ namespace Consensus {
   58 struct Params;
   59 } // namespace Consensus
   60 
   61-/** Default for -limitancestorcount, max number of in-mempool ancestors */
   62-static const unsigned int DEFAULT_ANCESTOR_LIMIT = 25;
   63 /** Default for -limitancestorsize, maximum kilobytes of tx + all in-mempool ancestors */
   

   ---

   ---

   

   glozow commented at 5:52 pm on June 7, 2022:

   The rest should be moved too, as stated in the comment.

   DEFAULT_ANCESTOR_LIMIT
   DEFAULT_ANCESTOR_SIZE_LIMIT
   DEFAULT_DESCENDANT_LIMIT
   DEFAULT_DESCENDANT_SIZE_LIMIT
   DEFAULT_MEMPOOL_EXPIRY
   

10. 
    DrahtBot commented at 1:07 am on June 8, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25373 (Support ignoring “opt-in” flag for RBF (aka full RBF) by luke-jr)
    • #25290 ([kernel 3a/n] Decouple CTxMemPool from ArgsManager by dongcarl)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    MarcoFalke commented at 8:41 am on June 15, 2022: member

    Closing for now due to inactivity. Since there hasn’t been any substantial discussion on this pull request, feel free to open a new one.

    If you do, make sure to squash the commits according to the contributing guidelines.

12. MarcoFalke closed this on Jun 15, 2022

    ---

13. 
    fanquake commented at 9:12 am on June 16, 2022: member

    Picked up in #25388.
14. laanwj referenced this in commit 57a491bee1 on Jun 20, 2022
15. DrahtBot locked this on Jun 16, 2023

Contributors
ghost glozow DrahtBot MarcoFalke fanquake

Labels
Mempool