23.x backports #25316

1. 
   fanquake commented at 11:26 AM on June 9, 2022: member

   Backports:

   • #24454
   • #25201
   • #25220
   • https://github.com/bitcoin/bitcoin/pull/25314
2. rpc: fix inappropriate warning for address type p2sh-segwit in createmultisig and addmultisigaddress

   Github-Pull: #25220
   Rebased-From: eaf6f630c0190c634b5f1c85f749437f4209cc36

   7658055c4e
3. test: ensure createmultisig and addmultisigaddress are not returning any warning for expected cases

   Github-Pull: #25220
   Rebased-From: 3a9b9bb38e653c8ff7220b9af6e337a90c2c22dc

   32fa522a80
4. windeploy: Renewed windows code signing certificate

   Github-Pull: #25201
   Rebased-From: 7e9fe6d800ee8f3381e8f6ad2371f7775c68fad9

   bd6d3ac8b7
5. tests: Calculate input weight more accurately

   The external input test with specifying input weight would make a
   pessimistic estimate of the input weight. However this would result in a
   test failure as it is sometimes too pessimistic when an ECDSA signature
   ends up being smaller than usual. To correct this, we can calculate the
   input weight more accurately.
   
   Github-Pull: #24454
   Rebased-From: 8a04a386f75d099f4b9864b0cdf7f26442b5801f

   5fd25eb9cb
6. tests: Use descriptor that requires both legacy and segwit

   Github-Pull: #24454
   Rebased-From: 9f5ab670e7c8165f161ec44dbd95778c5515ece0

   039ef215bc
7. fanquake added the label Backport on Jun 9, 2022
8. fanquake added this to the milestone 23.1 on Jun 9, 2022
9. 
   LarryRuane commented at 9:20 PM on June 9, 2022: contributor

   utACK 039ef215bc1268cefb645472d411993e5582486b I compared all 5 commit diffs with the source commit diffs, and the only one that differs is 32fa522a80c87231dc6194b982f64440c801b7d4 (this PR's second commit) due to merge conflicts with rpc_createmultisig.py (specifically, the change to use MiniWallet, which isn't being backported). But the conflicts look to be resolved correctly.

10. 
    jonatack commented at 4:32 PM on June 11, 2022: contributor

    Prepared a commit for backport, if helpful, in https://github.com/jonatack/bitcoin/commits/v23-backport-fix-rpcwait-with-netinfo-printing-negative-time-durations.

11. p2p: always set nTime for self-advertisements

    If we self-advertised to an inbound peer with the address they gave us,
    nTime was left default-initialized, so that our peer wouldn't relay it
    any further along.
    
    Github-Pull: #25314
    Rebased-From: 99b9e5f3a9fa29bbc1e45fc958470fbcc207ef23

    4ebf6e35dc
12. 
    LarryRuane commented at 7:33 PM on June 23, 2022: contributor

    re-utACK 4ebf6e35dcac936342525ec7b4b77a82c71693e7 Compared the latest commit, "p2p: always set nTime for self-advertisements" to the source commit, and they match.

13. 
    achow101 commented at 8:34 PM on July 7, 2022: member

    ACK 4ebf6e35dcac936342525ec7b4b77a82c71693e7

14. MarcoFalke merged this on Jul 8, 2022
15. MarcoFalke closed this on Jul 8, 2022

    ---

16. fanquake deleted the branch on Jul 8, 2022
17. bitcoin locked this on Jul 8, 2023

Milestone
23.1