guix: drop `-z,noexecstack` for PPC64 #25357

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:drop_noexecstack_for_ppc64 changing 3 files +36 −7
  1. fanquake commented at 12:32 PM on June 13, 2022: member

    The PPC64 ELF ABI has a non-executable stack by default, so passing -Wl,-z,noexecstack to force the creation of a GNU_STACK segment, just so we can assert that it doesn't have the exectable permission, is awkward. Now that LIEF has been fixed upstream, https://github.com/lief-project/LIEF/pull/718, we can temporarily patch our LIEF build to include the (simple) patch, and drop it the next time we update LIEF.

    See the relevant Linux kernel documentation for powerpc (and discussion in #25313):

    /*
 * This is the default if a program doesn't have a PT_GNU_STACK
 * program header entry. The PPC64 ELF ABI has a non executable stack
 * stack by default, so in the absence of a PT_GNU_STACK program header
 * we turn execute permission off.
 */
#define VM_STACK_DEFAULT_FLAGS32	VM_DATA_FLAGS_EXEC
#define VM_STACK_DEFAULT_FLAGS64	VM_DATA_FLAGS_NON_EXEC

#define VM_STACK_DEFAULT_FLAGS \
	(is_32bit_task() ? \
	 VM_STACK_DEFAULT_FLAGS32 : VM_STACK_DEFAULT_FLAGS64)

    Guix Build (x86_64):

    0df3f7a716b8c58c29990b0fbad17dbddb7a14d8e348bdabec7593771accaa2c  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/SHA256SUMS.part
f235d9fb0255a0dd3cca7005e4ee09623b01224372585a49be8f94569bd52617  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/bitcoin-5f082ad4e4cc-aarch64-linux-gnu-debug.tar.gz
8d870b415dcd30abc889c47f5313cb6a30ec7d0a29bab11394a90c612171a09d  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/bitcoin-5f082ad4e4cc-aarch64-linux-gnu.tar.gz
1f37b3ba87ab9f3aedc8f23251b423b146c1db9cc93d7cbe1ccb22a818cb597f  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/SHA256SUMS.part
515e13725241fe889208df0c4a678da83e06dfa77e0b47125b2bfd46cf784b11  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf-debug.tar.gz
d6051bde21d3b17c44af6925efcb68fcda5e0ae0bc42f167a36bea79205bd0f7  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf.tar.gz
3c12359285baa0d1696d855d220f235d5db44c1989e3e13d89cb555ca8f2bc01  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/SHA256SUMS.part
74853e41c40a7d12d08c83b8e77d0a007bb19465c1206b7b78d85e5dc4f08df1  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.dmg
570d3f9578715784c729acdaafaf67ebcefbf48c1da3f322813292803f275ccf  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.tar.gz
670e1f4b2825679d8e92b76f0a253dd11a9d8c484bf8a453068e63d99df7e1dd  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin.tar.gz
935deb771d847aab5feda557902225c49b6f2547f271072853f5a94a501885fd  guix-build-5f082ad4e4cc/output/dist-archive/bitcoin-5f082ad4e4cc.tar.gz
dce5d37e13ddc2482333fe5b0f6b3d5f29a2bfc38446088afeb3b2e3345c0753  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/SHA256SUMS.part
b65de56a98b6bd9dbdfa7cb4c92517804b936c7ed101475f2764283d1f3c0b6d  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu-debug.tar.gz
9d3cb775a467df2d653fc1670008bcf344303dd20f740e727c927ec5f9015aa8  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu.tar.gz
7f6cbaef349ed129a769bdae2adcff7f65d856f52f2caf25f4da44272058fbf0  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/SHA256SUMS.part
56435b4da1e96beefe0e2093f5c1cafac19d911fe3df667b6652e6641786a582  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu-debug.tar.gz
75a43ecdcd374d15543458251e4d7275551e08cff308483d3f54130fa18008a4  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu.tar.gz
a555d0164046d47ec32c5924657c74a3d481165096dd1b74050871e438563442  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/SHA256SUMS.part
fc4c430f34bea975f14b755574f4507b9972b873056d9cf55a165b1e2902ddae  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu-debug.tar.gz
a25a0fe2c5cf08fa8af588fe4e8c74276db5386ab44118ed6226de575b50cacd  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu.tar.gz
811fd6d62e02b6a3bf1a0e39d8721034398c1710649f080c81e514eb34e70500  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/SHA256SUMS.part
1a43bf4e0b56f9e724c45a7f5cc8f1641e038c450a62ab9baa68f6fe2f60da8a  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.dmg
8c2508bdf0256177b05fff4cd613b735deaacee844f74ae075dabdc911b35204  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.tar.gz
7cb121072661dc224914d6777135d51aa60f16c8dc890f840f81d39cc55ee7ed  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin.tar.gz
4ff472b2f9e786e620c449563c33f032795dada20701e9da9126997b2f9605e7  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/SHA256SUMS.part
1e0e4662a38f5df3027b4c062a18c6255fb59640afc69dd2e23a1dc47f278a74  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu-debug.tar.gz
0d02f5689b008818467d5fe14a10503738e0e6c96f34591771cb8fb0f2cd3763  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu.tar.gz
bff9e2893998b1880850f0195a8282564c4bf46d2bfaaf3358ddd7f1812370f1  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/SHA256SUMS.part
11e0835f989d86c6c39a8dfa60e7129262e098ef80720d0de6acfdcd8995fd92  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-debug.zip
491038e48288863860a3adf229a138d1b74a24004dcb1e07b28d207f866e7d15  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-setup-unsigned.exe
5c8cbbd00a0cb5fcb00478bd05cbb7fa38f97126c677538389173cf71f64f647  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-unsigned.tar.gz
a6ee1e220e8d91192ee6f36ef33a0c5a1348aba2f84fd42d228f04ab927f3feb  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64.zip

    Guix Build (arm64):

    17ec23ec07289eb00eec401385aca7e194d366f86778bd747ca17ad2bdded16f  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/SHA256SUMS.part
34b997bba0ec8c6f66bde5cd8d08cf2fbf6e5cb04d1825a4ef4b850c059841fa  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf-debug.tar.gz
93666cc53fd3a6cdfe3528f42a8250bc82bd7a1ab5936d99052bef49142e06c9  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf.tar.gz
c142bd730e1a564f9c0f65818fa3a0e3d20d41a95c419ce52b11ef33420d03ad  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/SHA256SUMS.part
afcf76d9807173a1dceb6c9933997f1cbac76fb9b683b6ad65af93069dbe7344  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.dmg
f1a6f2b8a01543b3f5926e880619c54317fdcb2e93ed860df5e0bb642a8e6d4c  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.tar.gz
e423a0cb964177d6ad97cebd288666460a902d45f51bacba23b019644ddeea18  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin.tar.gz
935deb771d847aab5feda557902225c49b6f2547f271072853f5a94a501885fd  guix-build-5f082ad4e4cc/output/dist-archive/bitcoin-5f082ad4e4cc.tar.gz
e01cf090da155bc7626d221a87a177b2dd1cdb8d9c2954e2423ab0268976e513  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/SHA256SUMS.part
08afcfc256bd8f29d1dad90709828ef800b2ea3d22b834dc78af27b5d10d20b5  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu-debug.tar.gz
cf861876542e8b27e9335ce9432107a402e8cc4b177d2db1649b54d7e269081e  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu.tar.gz
0840ae94ea6830d842043d4a8ed17893e3f58917113bcf2e2e3ee247bd8db249  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/SHA256SUMS.part
072251112d709f1c2a3b38065f5fb5a435f3cefbc788e46fa1ff9d96d746ea4d  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu-debug.tar.gz
a8507446c9a69a0c7fe1020e30d6f0334d0f6c0c96263298bafd502c2ce2c7c4  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu.tar.gz
d3cf62ebabb062276dd1615774c7ee231b62a92ba1a9515f13c1f0454d84c6e5  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/SHA256SUMS.part
0b738e9f973d2ed4031fd81465ea65bc9d17e983e48c892ca89582da9d8afcd5  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu-debug.tar.gz
28e84d55aa048be871776cd62c7dcbb6286d2f42ac1ce59772ea65217eb86ec2  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu.tar.gz
811fd6d62e02b6a3bf1a0e39d8721034398c1710649f080c81e514eb34e70500  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/SHA256SUMS.part
1a43bf4e0b56f9e724c45a7f5cc8f1641e038c450a62ab9baa68f6fe2f60da8a  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.dmg
8c2508bdf0256177b05fff4cd613b735deaacee844f74ae075dabdc911b35204  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.tar.gz
7cb121072661dc224914d6777135d51aa60f16c8dc890f840f81d39cc55ee7ed  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin.tar.gz
6463d3502cb839e50aaa2063f3ea1e4c874904e4745836411603e4cf0b5da946  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/SHA256SUMS.part
dae5e82e1a32312fb417aabeef750cb4317a853af142ec0a7125dcb6f66e7930  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu-debug.tar.gz
2434199cc24b8b463d3efda8a053d21324c02d1b06afaa3e08af7cdffa7b05d4  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu.tar.gz
8195c14785b4f553eb05fb8c25516d1b337b3ca8fc9d7cf6ad6d2bd3bc6d2093  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/SHA256SUMS.part
95b674ae6d9ddff652feeb5280e6a600803f78f685cde62f94332876c4039357  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-debug.zip
491038e48288863860a3adf229a138d1b74a24004dcb1e07b28d207f866e7d15  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-setup-unsigned.exe
5c8cbbd00a0cb5fcb00478bd05cbb7fa38f97126c677538389173cf71f64f647  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-unsigned.tar.gz
3e5fbbe50d266e6e03ae0976ccef74cf1024d107629223e655c672e2b8d73187  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64.zip
  2. fanquake added the label Build system on Jun 13, 2022
  3. fanquake added the label DrahtBot Guix build requested on Jun 13, 2022
  4. fanquake requested review from laanwj on Jun 13, 2022
  5. laanwj commented at 12:53 PM on June 13, 2022: member

    Looks good to me. Happy to get rid of the -Wl,-z,noexecstack for reasons mentioned here: #25313 (comment)

    FWIW, i filed an upstream PR already: lief-project/LIEF#718

  6. in contrib/devtools/security-check.py:185 in d5eae5f730 outdated 
     180 | +    # The PPC64 ABI uses a non-executable stack by default, and does not
 181 | +    # need a GNU_STACK program header.
 182 | +    # This can be dropped once LIEF is improved upstream:
 183 | +    # https://github.com/lief-project/LIEF/issues/717
 184 | +    arch = binary.abstract.header.architecture
 185 | +    binary.concrete
    laanwj commented at 12:57 PM on June 13, 2022:

    This line looks really strange.

    fanquake commented at 1:02 PM on June 13, 2022:

    Yes, this is a little awkward, and was what I was alluding to in the PR description. Ideally, I'd use if binary.header.machine_type == lief.ELF.ARCH.PPC64: here, but because this function is used across all binaries, not just ELF, that wont work, as, for example, the PE binary header doesn't have a machine_type. Instead, we use binary.abstract.header.architecture, however whenever you use .abstract, you have to use .concrete to case the binary back from the abstract type. See here: https://lief-project.github.io//doc/latest/api/python/abstract.html#binary.

    laanwj commented at 1:15 PM on June 13, 2022:

    Hm, might want to add a comment to that regard in-line.

    hebasto commented at 1:40 PM on June 13, 2022:

    Or always use binary.abstract or binary.concrete explicitly?

    fanquake commented at 1:48 PM on June 13, 2022:

    Or always use binary.abstract or binary.concrete explicitly?

    I'm not even sure that'd be possible, as you've got access to different functionality in either. In any case, a wholesale change like that isn't going to be part of this PR.

    laanwj commented at 2:27 PM on June 13, 2022:

    It's a temporary work-around, changing the whole code for it is probably not worth it (unless it's needed for other things too).

    fanquake commented at 3:17 PM on June 16, 2022:

    Resolving this as I'm dropping the workaround commit.

  7. laanwj commented at 4:35 AM on June 14, 2022: member

    Upstream PR was already merged! https://github.com/lief-project/LIEF/pull/718

    I kind of hope we can pull that in before the release, then we can skip having a work-around on our side?

  8. DrahtBot commented at 6:14 PM on June 14, 2022: member

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds

    File commit 3340d46cd363e568ce842b2a9930e30902d150ca<br>(master) commit d6871575023a4cd0f3da02e0b1816113864cde77<br>(master and this pull)
    SHA256SUMS.part 7db23d6a84d65af3... c4ed83076a300300...
    *-aarch64-linux-gnu-debug.tar.gz cd1dd85ab07f833b... 9d18b789447cc58b...
    *-aarch64-linux-gnu.tar.gz 195b9c6fad8ca62f... 0761a736f1c649cc...
    *-arm-linux-gnueabihf-debug.tar.gz 4cb5b2d92881f634... 95ab9bfde33a492d...
    *-arm-linux-gnueabihf.tar.gz 58460367cf0d5135... a786b13ec8b6f8d8...
    *-arm64-apple-darwin-unsigned.dmg 9cb0c1c3ed5172d2... 9cf63a6c21af0aea...
    *-arm64-apple-darwin-unsigned.tar.gz f73618a0be0e30a3... cca21c13b9175751...
    *-arm64-apple-darwin.tar.gz 99349cea13968164... 9fc0685150ff693f...
    *-powerpc64-linux-gnu-debug.tar.gz 822e85f632cdee68... b75ee8f1c6726b5b...
    *-powerpc64-linux-gnu.tar.gz 688617fefa9803cb... 2d514f9742c36d65...
    *-powerpc64le-linux-gnu-debug.tar.gz 586f89585cf95a36... 6289752d9e34b4ea...
    *-powerpc64le-linux-gnu.tar.gz e178efa8fc3e6fc4... bd22e779ded6560a...
    *-riscv64-linux-gnu-debug.tar.gz bd3e9a44ca0c6ef8... d2ed9ca20767ddb0...
    *-riscv64-linux-gnu.tar.gz 2963da28706c7e7f... 724396cb153ee9c7...
    *-win64-debug.zip 49aabb9dc84d61e7... a3713abf28c8519b...
    *-win64-setup-unsigned.exe 98fb0d972731f5dc... 39f620f19a9c33d5...
    *-win64-unsigned.tar.gz edc56add2e3904e0... 99e13b20a8f3c7a9...
    *-win64.zip 3b24ec2b1a9b5433... 372a8dc68e8619e2...
    *-x86_64-apple-darwin-unsigned.dmg a5f674bd1c65dfe8... c98351cb6363dc0b...
    *-x86_64-apple-darwin-unsigned.tar.gz e5193b2076f31751... 12543a566d86d892...
    *-x86_64-apple-darwin.tar.gz ea1a954836dda431... 9eecf8bfa7ff6243...
    *-x86_64-linux-gnu-debug.tar.gz 8756b2765423a28a... b52c0640c89b7a8f...
    *-x86_64-linux-gnu.tar.gz 0694ffe16b11728a... 685743895489aac9...
    *.tar.gz 0ac1d0b02590a244... 792d5836588c013b...
    guix_build.log 00d91e01d3364463... 48eb26f1448ac7d4...
    guix_build.log.diff 02e8dc0326ea288a...
  9. DrahtBot removed the label DrahtBot Guix build requested on Jun 14, 2022
  10. fanquake force-pushed on Jun 16, 2022
  11. fanquake commented at 3:31 PM on June 16, 2022: member

    Upstream PR was already merged!

    I've dropped the workaround, in favour of a commit (not-yet-mergable) that points us to the master branch of LIEF, to demonstrate that the upstream change is working. Will Add new hashes to op.

  12. laanwj commented at 6:08 PM on June 16, 2022: member

    Nice!

  13. jarolrod commented at 5:28 PM on June 17, 2022: member

    GUIX hashes on arm64, my hashes match @fanquake

    $ env HOSTS='arm-linux-gnueabihf arm64-apple-darwin powerpc64-linux-gnu powerpc64le-linux-gnu riscv64-linux-gnu x86_64-apple-darwin x86_64-linux-gnu x86_64-w64-mingw32' ./contrib/guix/guix-build 
$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

be67cac2e9765a36358489ae1d23cf5322e4c433dd2238fe036a084f0781b92c  guix-build-eea2c54827ca/output/arm-linux-gnueabihf/SHA256SUMS.part
8e0216653d33cb95d128f3cd723346d8bd586ab1041c044ab77acd20c44b1a27  guix-build-eea2c54827ca/output/arm-linux-gnueabihf/bitcoin-eea2c54827ca-arm-linux-gnueabihf-debug.tar.gz
212427e298e43ad5658f326cd1fa433930a9b9c084e9b10e07e79e934401b74b  guix-build-eea2c54827ca/output/arm-linux-gnueabihf/bitcoin-eea2c54827ca-arm-linux-gnueabihf.tar.gz
c6661bbd222d527a48cb5f79b0b936d9df33da5af643bd3c6fad9c503e7b6083  guix-build-eea2c54827ca/output/arm64-apple-darwin/SHA256SUMS.part
77728cbea8200b79dc7eedcf58cc7a37b8b45d522e10e9aba9bdad8954c2d1ba  guix-build-eea2c54827ca/output/arm64-apple-darwin/bitcoin-eea2c54827ca-arm64-apple-darwin-unsigned.dmg
0091f88984c6326b9a918542fcc11a8f2d58439a0c8766bb8fc15b3309cee6fe  guix-build-eea2c54827ca/output/arm64-apple-darwin/bitcoin-eea2c54827ca-arm64-apple-darwin-unsigned.tar.gz
a74c65a739a5e8ab1799ead43edd6171872c605a2837dfa2e61ad32bf9b3a295  guix-build-eea2c54827ca/output/arm64-apple-darwin/bitcoin-eea2c54827ca-arm64-apple-darwin.tar.gz
1c91ab3f294e98f6aa61e928c7e18b0aad8963e2dc4c673941b4794d55aa85f5  guix-build-eea2c54827ca/output/dist-archive/bitcoin-eea2c54827ca.tar.gz
58d4c4b3fb4b059b8ed9a8b63415bc98651182bc5de3ec266c6f1aef0f80d071  guix-build-eea2c54827ca/output/powerpc64-linux-gnu/SHA256SUMS.part
2a9610d04fcd495a33dcaf6d523fbc1d76b9856c1820d32330816c8a55f331de  guix-build-eea2c54827ca/output/powerpc64-linux-gnu/bitcoin-eea2c54827ca-powerpc64-linux-gnu-debug.tar.gz
6a55d0855f7e76cbcee9746d6d9ed35741cce30202a98eab303953f876d96480  guix-build-eea2c54827ca/output/powerpc64-linux-gnu/bitcoin-eea2c54827ca-powerpc64-linux-gnu.tar.gz
73d7792e1a8acdf16870ee6096d276208754aaeac1916321ede140c6e927fed6  guix-build-eea2c54827ca/output/powerpc64le-linux-gnu/SHA256SUMS.part
1bac6a11c7335373df1d0d471c45d63fd57bb1846121e127707f1ba26944cc13  guix-build-eea2c54827ca/output/powerpc64le-linux-gnu/bitcoin-eea2c54827ca-powerpc64le-linux-gnu-debug.tar.gz
707a6b21772acc66b9c8707ef8920496abbc1c55ac598640fe93331bdd3d2067  guix-build-eea2c54827ca/output/powerpc64le-linux-gnu/bitcoin-eea2c54827ca-powerpc64le-linux-gnu.tar.gz
27dd95810292f97b60b020ed16cd50fb39f3a045a5647559e32ac6e3a3bc8b99  guix-build-eea2c54827ca/output/riscv64-linux-gnu/SHA256SUMS.part
015c99bf3aee52bb78515acbae462f698f501c9952ba42d64cfd7fb5bd146a12  guix-build-eea2c54827ca/output/riscv64-linux-gnu/bitcoin-eea2c54827ca-riscv64-linux-gnu-debug.tar.gz
9b3d45f06e27b9da5ba7dbd705049156fd1d48fd02e64cbdad831036ec5bde5b  guix-build-eea2c54827ca/output/riscv64-linux-gnu/bitcoin-eea2c54827ca-riscv64-linux-gnu.tar.gz
d270b67edae2dc6765d2b2071fe90a8b91e368b1c0a3b8726ca0d7f53956503b  guix-build-eea2c54827ca/output/x86_64-apple-darwin/SHA256SUMS.part
a9fe4898f2c511582c4af5d649c56b72201593922ee6f8a600b37629c611e7e0  guix-build-eea2c54827ca/output/x86_64-apple-darwin/bitcoin-eea2c54827ca-x86_64-apple-darwin-unsigned.dmg
8a2b0b312db303aab39ac651ef5f2a08b0388f8a55f1e4ee0908e597c301c33e  guix-build-eea2c54827ca/output/x86_64-apple-darwin/bitcoin-eea2c54827ca-x86_64-apple-darwin-unsigned.tar.gz
0e035d09f8c804c8d7fd6ea67821de730687eb5fc54186a55067135cea4916f5  guix-build-eea2c54827ca/output/x86_64-apple-darwin/bitcoin-eea2c54827ca-x86_64-apple-darwin.tar.gz
088891128076039a8aa77d347805b8906004e96e514215ee559e8b0b86d8b62f  guix-build-eea2c54827ca/output/x86_64-linux-gnu/SHA256SUMS.part
11f5a0868a42fa2f227b103631a70a1f4c36e0b82bcb7ca31464c7e734ec4c2a  guix-build-eea2c54827ca/output/x86_64-linux-gnu/bitcoin-eea2c54827ca-x86_64-linux-gnu-debug.tar.gz
b7056413a48238e35d5f3193a05d046611507f7d4d2d50baecf8bc8af7b249e9  guix-build-eea2c54827ca/output/x86_64-linux-gnu/bitcoin-eea2c54827ca-x86_64-linux-gnu.tar.gz
d1e6b11b9a0ee8d26d4585c03d53e04cd8757e8fcccec0d3a3c58c5dcde17bde  guix-build-eea2c54827ca/output/x86_64-w64-mingw32/SHA256SUMS.part
686446715c55e0ad457d0cdc8cf8f9bddef1ab6e6f49af272069040807370583  guix-build-eea2c54827ca/output/x86_64-w64-mingw32/bitcoin-eea2c54827ca-win64-debug.zip
8ff4a1def08a4e916dc9b407d5a2a1b917018b32dafeebdc85450d0540582f9d  guix-build-eea2c54827ca/output/x86_64-w64-mingw32/bitcoin-eea2c54827ca-win64-setup-unsigned.exe
3e1a61d93a3e3d91695592c4d6537aab05ac0196f3fba0b0a52c418fc41c7c15  guix-build-eea2c54827ca/output/x86_64-w64-mingw32/bitcoin-eea2c54827ca-win64-unsigned.tar.gz
59d170a3b7a47334d02f19fb541034d928eb732bff559e4aaf7dea99b1f31441  guix-build-eea2c54827ca/output/x86_64-w64-mingw32/bitcoin-eea2c54827ca-win64.zip
  14. DrahtBot commented at 12:34 AM on June 21, 2022: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  15. laanwj commented at 9:34 AM on June 22, 2022: member

    I've dropped the workaround, in favour of a commit (not-yet-mergable) that points us to the master branch of LIE

    We might want to change the PR to draft if it's not yet meant to be merged. I suppose the idea is to wait for a LIEF release?

  16. fanquake commented at 10:12 AM on June 22, 2022: member

    I suppose the idea is to wait for a LIEF release?

    Yes I think we can just wait for now. Will draft this PR.

  17. fanquake marked this as a draft on Jun 22, 2022
  18. guix: remove usage of -Wl,-z,noexecstack for PPC64 HOST
    The PPC64 ABI has a non-executable stack by default, and does not need a
GNU_STACK program header.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm/page_64.h#n92
    4b6b4fc537
  19. guix: use LIEF 0.12.1 0b5adfda87
  20. fanquake force-pushed on Jun 25, 2022
  21. fanquake marked this as ready for review on Jun 25, 2022
  22. guix: patch LIEF to fix PPC64 NX default
    This patches our LIEF build using the change merged upstream:
https://github.com/lief-project/LIEF/pull/718.

This can be dropped the next time we update LIEF.
    5f082ad4e4
  23. fanquake force-pushed on Jun 25, 2022
  24. fanquake commented at 9:05 AM on June 25, 2022: member

    We might want to change the PR to draft if it's not yet meant to be merged. I suppose the idea is to wait for a LIEF release?

    I've changed the approach, and am going to un-draft. Your patch is staight-forward enough that we can just temporarily cherry-pick it into our LIEF build, and drop it the next time we update LIEF. Rebased this on master post #25458.

  25. laanwj commented at 3:30 PM on June 26, 2022: member

    Agree with this approach (I didn't suggest it before because I wasn't sure it was practical). Will do a guix build to check the output and reproducibility.

  26. laanwj commented at 5:23 PM on June 26, 2022: member

    Output matches yours:

    find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
0df3f7a716b8c58c29990b0fbad17dbddb7a14d8e348bdabec7593771accaa2c  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/SHA256SUMS.part
f235d9fb0255a0dd3cca7005e4ee09623b01224372585a49be8f94569bd52617  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/bitcoin-5f082ad4e4cc-aarch64-linux-gnu-debug.tar.gz
8d870b415dcd30abc889c47f5313cb6a30ec7d0a29bab11394a90c612171a09d  guix-build-5f082ad4e4cc/output/aarch64-linux-gnu/bitcoin-5f082ad4e4cc-aarch64-linux-gnu.tar.gz
1f37b3ba87ab9f3aedc8f23251b423b146c1db9cc93d7cbe1ccb22a818cb597f  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/SHA256SUMS.part
515e13725241fe889208df0c4a678da83e06dfa77e0b47125b2bfd46cf784b11  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf-debug.tar.gz
d6051bde21d3b17c44af6925efcb68fcda5e0ae0bc42f167a36bea79205bd0f7  guix-build-5f082ad4e4cc/output/arm-linux-gnueabihf/bitcoin-5f082ad4e4cc-arm-linux-gnueabihf.tar.gz
3c12359285baa0d1696d855d220f235d5db44c1989e3e13d89cb555ca8f2bc01  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/SHA256SUMS.part
74853e41c40a7d12d08c83b8e77d0a007bb19465c1206b7b78d85e5dc4f08df1  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.dmg
570d3f9578715784c729acdaafaf67ebcefbf48c1da3f322813292803f275ccf  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin-unsigned.tar.gz
670e1f4b2825679d8e92b76f0a253dd11a9d8c484bf8a453068e63d99df7e1dd  guix-build-5f082ad4e4cc/output/arm64-apple-darwin/bitcoin-5f082ad4e4cc-arm64-apple-darwin.tar.gz
935deb771d847aab5feda557902225c49b6f2547f271072853f5a94a501885fd  guix-build-5f082ad4e4cc/output/dist-archive/bitcoin-5f082ad4e4cc.tar.gz
dce5d37e13ddc2482333fe5b0f6b3d5f29a2bfc38446088afeb3b2e3345c0753  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/SHA256SUMS.part
b65de56a98b6bd9dbdfa7cb4c92517804b936c7ed101475f2764283d1f3c0b6d  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu-debug.tar.gz
9d3cb775a467df2d653fc1670008bcf344303dd20f740e727c927ec5f9015aa8  guix-build-5f082ad4e4cc/output/powerpc64-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64-linux-gnu.tar.gz
7f6cbaef349ed129a769bdae2adcff7f65d856f52f2caf25f4da44272058fbf0  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/SHA256SUMS.part
56435b4da1e96beefe0e2093f5c1cafac19d911fe3df667b6652e6641786a582  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu-debug.tar.gz
75a43ecdcd374d15543458251e4d7275551e08cff308483d3f54130fa18008a4  guix-build-5f082ad4e4cc/output/powerpc64le-linux-gnu/bitcoin-5f082ad4e4cc-powerpc64le-linux-gnu.tar.gz
a555d0164046d47ec32c5924657c74a3d481165096dd1b74050871e438563442  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/SHA256SUMS.part
fc4c430f34bea975f14b755574f4507b9972b873056d9cf55a165b1e2902ddae  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu-debug.tar.gz
a25a0fe2c5cf08fa8af588fe4e8c74276db5386ab44118ed6226de575b50cacd  guix-build-5f082ad4e4cc/output/riscv64-linux-gnu/bitcoin-5f082ad4e4cc-riscv64-linux-gnu.tar.gz
811fd6d62e02b6a3bf1a0e39d8721034398c1710649f080c81e514eb34e70500  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/SHA256SUMS.part
1a43bf4e0b56f9e724c45a7f5cc8f1641e038c450a62ab9baa68f6fe2f60da8a  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.dmg
8c2508bdf0256177b05fff4cd613b735deaacee844f74ae075dabdc911b35204  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin-unsigned.tar.gz
7cb121072661dc224914d6777135d51aa60f16c8dc890f840f81d39cc55ee7ed  guix-build-5f082ad4e4cc/output/x86_64-apple-darwin/bitcoin-5f082ad4e4cc-x86_64-apple-darwin.tar.gz
4ff472b2f9e786e620c449563c33f032795dada20701e9da9126997b2f9605e7  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/SHA256SUMS.part
1e0e4662a38f5df3027b4c062a18c6255fb59640afc69dd2e23a1dc47f278a74  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu-debug.tar.gz
0d02f5689b008818467d5fe14a10503738e0e6c96f34591771cb8fb0f2cd3763  guix-build-5f082ad4e4cc/output/x86_64-linux-gnu/bitcoin-5f082ad4e4cc-x86_64-linux-gnu.tar.gz
bff9e2893998b1880850f0195a8282564c4bf46d2bfaaf3358ddd7f1812370f1  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/SHA256SUMS.part
11e0835f989d86c6c39a8dfa60e7129262e098ef80720d0de6acfdcd8995fd92  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-debug.zip
491038e48288863860a3adf229a138d1b74a24004dcb1e07b28d207f866e7d15  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-setup-unsigned.exe
5c8cbbd00a0cb5fcb00478bd05cbb7fa38f97126c677538389173cf71f64f647  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64-unsigned.tar.gz
a6ee1e220e8d91192ee6f36ef33a0c5a1348aba2f84fd42d228f04ab927f3feb  guix-build-5f082ad4e4cc/output/x86_64-w64-mingw32/bitcoin-5f082ad4e4cc-win64.zip

    Tested ACK 5f082ad4e4cc59ccc0ea32626a69522abba71e0d

  27. laanwj merged this on Jun 27, 2022
  28. laanwj closed this on Jun 27, 2022
  29. fanquake deleted the branch on Jun 27, 2022
  30. sidhujag referenced this in commit 3ecfa54db3 on Jun 27, 2022
  31. kittywhiskers referenced this in commit 147b5de0f3 on May 13, 2023
  32. kittywhiskers referenced this in commit 466ab67a45 on May 13, 2023
  33. kittywhiskers referenced this in commit 443a4bfa49 on May 13, 2023
  34. kittywhiskers referenced this in commit 3576f364dd on May 19, 2023
  35. kittywhiskers referenced this in commit a852d04351 on May 31, 2023
  36. kittywhiskers referenced this in commit 59445ab96c on May 31, 2023
  37. kittywhiskers referenced this in commit 659e42be25 on Jun 3, 2023
  38. kittywhiskers referenced this in commit 899a476b2c on Jun 6, 2023
  39. kittywhiskers referenced this in commit 68761d7883 on Jun 7, 2023
  40. kittywhiskers referenced this in commit 936c3e9213 on Jun 8, 2023
  41. kittywhiskers referenced this in commit 963b65fff9 on Jun 10, 2023
  42. kittywhiskers referenced this in commit 65d960df34 on Jun 11, 2023
  43. kittywhiskers referenced this in commit 9a4f06d3ef on Jun 11, 2023
  44. kittywhiskers referenced this in commit a5dd6e5828 on Jun 11, 2023
  45. kittywhiskers referenced this in commit 4fe79c16c1 on Jun 19, 2023
  46. kittywhiskers referenced this in commit 7481b5d407 on Jun 20, 2023
  47. kittywhiskers referenced this in commit fb839270a3 on Jun 20, 2023
  48. kittywhiskers referenced this in commit d69150567c on Jun 20, 2023
  49. kittywhiskers referenced this in commit 3b1f55a6dc on Jun 20, 2023
  50. kittywhiskers referenced this in commit 13fed24614 on Jun 20, 2023
  51. kittywhiskers referenced this in commit 65203669f6 on Jun 20, 2023
  52. kittywhiskers referenced this in commit fe0bfd5046 on Jun 21, 2023
  53. kittywhiskers referenced this in commit 741fb090b0 on Jun 22, 2023
  54. kittywhiskers referenced this in commit a8544d4457 on Jun 25, 2023
  55. kittywhiskers referenced this in commit 1dd7676c6e on Jun 25, 2023
  56. DrahtBot locked this on Jun 27, 2023
Contributors
fanquakelaanwjhebastoDrahtBotjarolrod
Labels
Build system
Linked (view graph)
#25313 guix: re-revert risc-v execstack workaround
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-25 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me