doc: Update importaddress mention incompatibility with descriptor wallet #25368

1. 
   brokenprogrammer commented at 10:38 am on June 14, 2022: contributor

   This is related to #25363 and offers a small update to the error messages from EnsureLegacyScriptPubKeyMan and EnsureConstLegacyScriptPubKeyMan to mention that they only are compatible with legacy wallets.

   The RPC documentation for importaddress is also updated to mention this as well as guide the user to the alternative importdescriptors for cases when using descriptor wallets.

   I’m thinking that we can introduce a “porting guide” document mentioned in #25363 in a separate PR since I would have to make myself more familiar with the subject before being able to tackle that.

2. DrahtBot added the label Refactoring on Jun 14, 2022
3. 
   laanwj commented at 12:09 pm on June 14, 2022: member

   Concept ACK
4. 
   theStack commented at 1:19 pm on June 14, 2022: member

   Concept ACK

   Note that in general the tests should pass at each commit, i.e. error message changes and test adaptions should be part of the same commit.

5. 
   brunoerg commented at 2:05 pm on June 14, 2022: member

   Concept ACK
6. 
   brokenprogrammer commented at 5:32 pm on June 14, 2022: contributor

   Note that in general the tests should pass at each commit, i.e. error message changes and test adaptions should be part of the same commit.

   Sorry about that I didn’t know. Let me know if I should fix it.

7. 
   achow101 commented at 6:37 pm on June 14, 2022: member

   Please squash your commits so that the tests change when the errors change.
8. brokenprogrammer force-pushed on Jun 14, 2022
9. doc: Update importaddress mention incompatibility with descriptor wallet e3609cdc01
10. brokenprogrammer force-pushed on Jun 14, 2022
11. 
    brokenprogrammer commented at 6:56 pm on June 14, 2022: contributor

    Please squash your commits so that the tests change when the errors change.

    Done! Also noticed a missing space after \"addr(X)\" hence force pushing twice.

12. in test/functional/wallet_descriptor.py:96 in e3609cdc01

    100-        assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.addmultisigaddress, 1, [recv_wrpc.getnewaddress()])
    101-        assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.dumpprivkey, recv_wrpc.getnewaddress())
    102-        assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.dumpwallet, 'wallet.dump')
    103-        assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.importwallet, 'wallet.dump')
    104-        assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.sethdseed)
    105+        assert_raises_rpc_error(-4, "Only legacy wallets are supported by this command", recv_wrpc.rpc.importprivkey, "cVpF924EspNh8KjYsfhgY96mmxvT6DgdWiTYMtMjuM74hJaU5psW")
    

    ---

    ---

    

    laanwj commented at 7:51 am on June 15, 2022:

    Some of these other RPCs could use porting documentation too (not in this PR, but may keep #25363 open and rename it).
13. 
    laanwj commented at 7:54 am on June 15, 2022: member

    Code review ACK e3609cdc01cf992800f28b20b0107b7fdc1f880e
14. 
    achow101 commented at 5:35 pm on June 15, 2022: member

    ACK e3609cdc01cf992800f28b20b0107b7fdc1f880e
15. achow101 merged this on Jun 15, 2022
16. achow101 closed this on Jun 15, 2022

    ---

17. sidhujag referenced this in commit 44b71da40e on Jun 15, 2022
18. JOHNJOHN2133 referenced this in commit b48a80a1c8 on Jul 24, 2022
19. achow101 referenced this in commit 071308860a on May 1, 2023
20. sidhujag referenced this in commit 042478444a on May 1, 2023
21. DrahtBot locked this on Jun 15, 2023

Contributors
brokenprogrammer laanwj theStack brunoerg achow101

Labels
Refactoring