wallet: fix warning: "argument name 'feerate' in comment does not match parameter name" #25410

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2022_wallet_25005_follow-up changing 1 files +7 −8

furszy commented at 1:30 PM on June 18, 2022: member

Should solve the tiny #25005 (comment).

Which merely happens for the extra "=" character after the comma.

Empact commented at 2:34 PM on June 18, 2022: member

Thoughts on flipping this around, to properly document the args?:

   return AvailableCoins(wallet, coinControl,
        /*feerate=*/ std::nullopt, 
        /*nMinimumAmount=*/ 1,           
        /*nMaximumAmount=*/ MAX_MONEY,
        /*nMinimumSumAmount=*/ MAX_MONEY,
        /*nMaximumCount=*/ 0
    ).total_amount;

DrahtBot added the label Wallet on Jun 18, 2022
wallet: fix warning: "argument name 'feerate' in comment does not match parameter name"
Happened because the "feerate=" comment was after the comma.
7ca8726f63
furszy force-pushed on Jun 18, 2022
furszy commented at 3:50 PM on June 18, 2022: member

Thoughts on flipping this around, to properly document the args?

Flipped 👍🏼

in src/wallet/spend.cpp:240 in 7ca8726f63

 243 | +    return AvailableCoins(wallet, coinControl,
 244 | +            /*feerate=*/ std::nullopt,
 245 | +            /*nMinimumAmount=*/ 1,
 246 | +            /*nMaximumAmount=*/ MAX_MONEY,
 247 | +            /*nMinimumSumAmount=*/ MAX_MONEY,
 248 | +            /*nMaximumCount=*/ 0

Empact commented at 4:01 PM on June 18, 2022:

nit: could de-dent this to the standard 4 spaces

Empact commented at 4:01 PM on June 18, 2022: member

Code Review ACK https://github.com/bitcoin/bitcoin/pull/25410/commits/7ca8726f6355f8738e9c49533d028123051a624b
maflcko merged this on Jun 18, 2022
maflcko closed this on Jun 18, 2022
w0xlt commented at 4:57 PM on June 18, 2022: contributor

Post-merge ACK https://github.com/bitcoin/bitcoin/pull/25410/commits/7ca8726f6355f8738e9c49533d028123051a624b
furszy deleted the branch on May 27, 2023
bitcoin locked this on May 26, 2024

Contributors

Labels

Linked (view graph)

#25005 wallet: remove extra wtx lookup in 'AvailableCoins' + several code cleanups.