build: GCC-12 build improvements #25436

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:libxkbcommon_gcc_12 changing 2 files +10 −0
  1. fanquake commented at 10:05 am on June 21, 2022: member

    2 changes to better support building with GCC 12, which out of the box, is currently broken if you want to build using depends. Prevent -Warray-bounds errors when building libxkbcommon. i.e:

    0src/xkbcomp/ast-build.c:82:27: error: array subscript 'ExprDef[0]' is partly outside array bounds of 'unsigned char[32]' [-Werror=array-bounds]
    1   82 |     expr->expr.value_type = type;
    2      |     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
    3src/xkbcomp/ast-build.c:75:21: note: object of size 32 allocated by 'malloc'
    4   75 |     ExprDef *expr = malloc(size);
    5      |                     ^~~~~~~~~~~~
    

    It might be the case that these would be fixed by updating the package, but that would also require installing new build tools (meson), as well as potentially more dependencies (wayland), and it’d need testing with Qt. For now, just turn the errors into wanrings.

    Define BOOST_NO_CXX98_FUNCTION_BASE to prevent GCC warning about the use of std::unary_function. i.e:

    0/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/container_hash/hash.hpp:131:33:
    1warning: 'template<class _Arg, class _Result> struct std::unary_function' is deprecated [-Wdeprecated-declarations]
    2  131 |         struct hash_base : std::unary_function<T, std::size_t> {};
    3      |                                 ^~~~~~~~~~~~~~
    4In file included from /usr/include/c++/12/bits/unique_ptr.h:37,
    5                 from /usr/include/c++/12/memory:76,
    6                 from ./init.h:10,
    7                 from init.cpp:10:
    8/usr/include/c++/12/bits/stl_function.h:117:12: note: declared here
    9  117 |     struct unary_function
    

    Boost container_hash (included via functional -> multi_index) uses std::unary_function, which was deprecated in C++11, and “removed” in C++17. It’s use causes warnings with newer compilers, i.e GCC 12.1.

    Use the MACRO outlined in https://github.com/boostorg/container_hash/issues/22, and added to Boost Config for GCC 12 in https://github.com/boostorg/config/pull/430, to prevent it’s use.

    BOOST_NO_CXX98_FUNCTION_BASE:

    The standard library no longer supports std::unary_function and std::binary_function. They were deprecated in C++11 and is removed from C++14.

    Guix Build (x86_64):

    Guix Build (arm64):

  2. fanquake added the label Build system on Jun 21, 2022
  3. fanquake added the label DrahtBot Guix build requested on Jun 21, 2022
  4. fanquake force-pushed on Jun 22, 2022
  5. jarolrod commented at 5:49 am on June 23, 2022: member

    GUIX hashes

    x86:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
     1
     2648beb27bb60aad6b88c0865293738665d55421cb863a17ced246ea4fad5f18c  guix-build-f1df4dd2878a/output/aarch64-linux-gnu/SHA256SUMS.part
     30901076bb0055522b0d733b7efc51afedec82b8ba4d3c8fb5cfb80dc8e5d58d6  guix-build-f1df4dd2878a/output/aarch64-linux-gnu/bitcoin-f1df4dd2878a-aarch64-linux-gnu-debug.tar.gz
     4e743b9acd4e6e3263328896409e37b0e702637294b435f09cde899f6d123bcb6  guix-build-f1df4dd2878a/output/aarch64-linux-gnu/bitcoin-f1df4dd2878a-aarch64-linux-gnu.tar.gz
     5cf37822a0a23af22a22d3b3447dc8540cae604df68881625948e151ff6d978b9  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/SHA256SUMS.part
     6a2373bc8e084697bbec1e08b40dc3d85d08dd922cea34b99739b79ce35d07ee2  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/bitcoin-f1df4dd2878a-arm-linux-gnueabihf-debug.tar.gz
     72092364a132b6028f0c5c3a8b8a716fbd592089245ad74c1b8261da88dbd0e88  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/bitcoin-f1df4dd2878a-arm-linux-gnueabihf.tar.gz
     86568fcfd0babeace56362e6921490ab50a6a84ee28aa248606df27d3cd862383  guix-build-f1df4dd2878a/output/arm64-apple-darwin/SHA256SUMS.part
     9fe98876ec35eded87e464ced7c90f3dcfc7961e23b03ef0e3e6e9c4ecf9b35bf  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin-unsigned.dmg
    109cf0fb7c2b430c877e828aa4c942e3ffbee2f36d6acbf783dde9735e672ba6ce  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin-unsigned.tar.gz
    11f18ebae8ac75518dd21555c69bfed16a6a0a5b2590afaf96e6a6ffff9bc34d7f  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin.tar.gz
    12d939b5050fe48bade289a6209a147e9b2685d8784c7d328321462aa573724440  guix-build-f1df4dd2878a/output/dist-archive/bitcoin-f1df4dd2878a.tar.gz
    133ec352d2321a358d1009b4ce0635782989de509b0dc82e9254e222b0a9220bf9  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/SHA256SUMS.part
    14d1fc1df89ba92debdc7ca1f865edbbf6d86365a2ffbf426705f708c494defe1e  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/bitcoin-f1df4dd2878a-powerpc64-linux-gnu-debug.tar.gz
    15ec15d97095b46b85e68dafce1f80639cccb6baa3cb141dcda1d65a646b135d57  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/bitcoin-f1df4dd2878a-powerpc64-linux-gnu.tar.gz
    160b4dd2a8beb64513b14e5ce14004d25b3bc59bdff7401594f8278e5ebf682871  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/SHA256SUMS.part
    17d72d5fd1aa3626cae8599cc51d0a4a19612edd4ae13c49dce9f9334a9a7c9037  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/bitcoin-f1df4dd2878a-powerpc64le-linux-gnu-debug.tar.gz
    1857ed26b03b28cc00e7ae49fac049e43bb39fa57b33bbfaae5a1d37a515287fe7  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/bitcoin-f1df4dd2878a-powerpc64le-linux-gnu.tar.gz
    1915847353a751ccc323040e2c05033860a2c4a77381b1e87fe3c7a158fd1c0ffc  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/SHA256SUMS.part
    208a8620d52cc639da368adb79c57337cbb4ec0e17233f8fdbd18760f4700a364b  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/bitcoin-f1df4dd2878a-riscv64-linux-gnu-debug.tar.gz
    213d647c1e21d590b73758baf8f2a87adf0230d6ced9ac1310f8f3db3d50095789  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/bitcoin-f1df4dd2878a-riscv64-linux-gnu.tar.gz
    225df51ce85386708b33c8004394e6a120eaee62c80bc6f928f1addc1d87cb8f90  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/SHA256SUMS.part
    2353ee3557b921c2c218ecfca89896eb0e547f652dea26a2630a0b13203f66f73d  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin-unsigned.dmg
    24be21aec933ce47ca5a8fc0838e211aaf8f11234e3b5f29a17a1589914c764121  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin-unsigned.tar.gz
    2537e3e633584e4a7060cda581a6097df769b9d2195a28654bc07e2bf1cb4576f5  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin.tar.gz
    26d2f0835c7fa07e37f551035db1300c5b631e17d28c0bc88146a053bc12a49ec7  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/SHA256SUMS.part
    27d99d9e7bae361ed981ffad52c7c42c1e7952d9e237f27f452981c32f379c64bb  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/bitcoin-f1df4dd2878a-x86_64-linux-gnu-debug.tar.gz
    28df36401321423afab0bd7a9bb53f2f6f8368ff3bdb80209a192512a6673106c7  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/bitcoin-f1df4dd2878a-x86_64-linux-gnu.tar.gz
    29b41a34bce877a47eacf57eb04ca628f9310a4bd3756a7054b33c3ffa6f9ac52b  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/SHA256SUMS.part
    306c1ca19f54943e4a246693698319c6b89df3a7ca7125d26ce7b73d39bf5e052f  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-debug.zip
    31ea952cb4db8776e0b9250aed8653e309ea8824b4763853a86ef41d2912a3b99d  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-setup-unsigned.exe
    32b5f92fc5d319beacb8b5de4af8f9ed1da5e2465246f8f1f1496378cf1aa0a17d  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-unsigned.tar.gz
    33b45750ff21a0f88024ca34590022f71612ca369b5b98e503b3ac10231cd25c67  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64.zip
    

    arm64:

     0$ env HOSTS='arm-linux-gnueabihf arm64-apple-darwin powerpc64-linux-gnu powerpc64le-linux-gnu riscv64-linux-gnu x86_64-apple-darwin x86_64-linux-gnu x86_64-w64-mingw32' ./contrib/guix/guix-build 
     1$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
     2
     3786574be2c3cdf441063176cae08022ccbc972cb726db6036af75e6135b8526d  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/SHA256SUMS.part
     4f5713390465c3436cb8e1bbbab0b48bf22bda8806217920aac47580091febf1f  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/bitcoin-f1df4dd2878a-arm-linux-gnueabihf-debug.tar.gz
     5b9cea2eede64b04fff90840756aa91984b9fd91883fb865aadd0fdbfe25d7e44  guix-build-f1df4dd2878a/output/arm-linux-gnueabihf/bitcoin-f1df4dd2878a-arm-linux-gnueabihf.tar.gz
     646cf3d62d7af325a27a3538181ab6bc2e1bbe76c6727dbefcb64bcd288d279d7  guix-build-f1df4dd2878a/output/arm64-apple-darwin/SHA256SUMS.part
     70bc9f95d1f6172771b3f120198a9a872b4f4e3a0732c28af8b47ef642b2072e3  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin-unsigned.dmg
     822f49c433914e7ff1fdf94955610085b41e9c72843c7b80bff02dd3d8721cb1d  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin-unsigned.tar.gz
     908cff7673fd2a4c48eb7dbbbb62f8071bfce9a3f0945f9c481d8f7cde63571bf  guix-build-f1df4dd2878a/output/arm64-apple-darwin/bitcoin-f1df4dd2878a-arm64-apple-darwin.tar.gz
    10d939b5050fe48bade289a6209a147e9b2685d8784c7d328321462aa573724440  guix-build-f1df4dd2878a/output/dist-archive/bitcoin-f1df4dd2878a.tar.gz
    111f2642ebc66383d2a6205ca81518a295d1b0ea202f1fa09464c7b2425538b738  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/SHA256SUMS.part
    1268c8c1be9442526ad443ef9cc8bdc379072774e29f6485c0cce57e3b15ee11d7  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/bitcoin-f1df4dd2878a-powerpc64-linux-gnu-debug.tar.gz
    1352392f88ebe624249849b1bbe6ac7a7b6877b224b21fde3dee49a73d9c20a8c8  guix-build-f1df4dd2878a/output/powerpc64-linux-gnu/bitcoin-f1df4dd2878a-powerpc64-linux-gnu.tar.gz
    14bd192cffeef86406bdb817917227bc6a9f9082f936db3ae56d91b2e9029a3279  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/SHA256SUMS.part
    1514e1b4f84fed5e3e80984d080019e48f8e6b9842309739a6455dc8ab987cd452  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/bitcoin-f1df4dd2878a-powerpc64le-linux-gnu-debug.tar.gz
    1670aafcaf0407f63a8f46a993dcd8073a3218194da9ba999c089a19129f9aa722  guix-build-f1df4dd2878a/output/powerpc64le-linux-gnu/bitcoin-f1df4dd2878a-powerpc64le-linux-gnu.tar.gz
    173271d07f27779ed87aba20b9e41ae0f40a554cf21b5dd047113a0b9261ef8f1c  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/SHA256SUMS.part
    18259eb63edb57afa098d7ede2c280df062413416fc4b2fed4d44ab419aa0d3465  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/bitcoin-f1df4dd2878a-riscv64-linux-gnu-debug.tar.gz
    19485de4fc1a7cfde0b3a177a6948cf5928899b4f8f7dad21479a1e2ce54a29a1b  guix-build-f1df4dd2878a/output/riscv64-linux-gnu/bitcoin-f1df4dd2878a-riscv64-linux-gnu.tar.gz
    205df51ce85386708b33c8004394e6a120eaee62c80bc6f928f1addc1d87cb8f90  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/SHA256SUMS.part
    2153ee3557b921c2c218ecfca89896eb0e547f652dea26a2630a0b13203f66f73d  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin-unsigned.dmg
    22be21aec933ce47ca5a8fc0838e211aaf8f11234e3b5f29a17a1589914c764121  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin-unsigned.tar.gz
    2337e3e633584e4a7060cda581a6097df769b9d2195a28654bc07e2bf1cb4576f5  guix-build-f1df4dd2878a/output/x86_64-apple-darwin/bitcoin-f1df4dd2878a-x86_64-apple-darwin.tar.gz
    240f5da3d9f13e90655590557a7bc149a5b5dab053ebf58898b86c65031e4faefe  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/SHA256SUMS.part
    252ff7939c671540357d8a35a66dbd726793c737b5a55ab07532c63747551e177c  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/bitcoin-f1df4dd2878a-x86_64-linux-gnu-debug.tar.gz
    2697356b7afb6c3e2e7a9173a7bd0c906d448c71ca0febd3d145b07910fee06a29  guix-build-f1df4dd2878a/output/x86_64-linux-gnu/bitcoin-f1df4dd2878a-x86_64-linux-gnu.tar.gz
    27271d2650e7cd4d070c232f56dd31fe460f6601c326bdfddf282e13d210754ab0  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/SHA256SUMS.part
    2845db4acb362c94cf7b77f49ec0059f66ef9db34bb3052038c0ac92f9a2806c8a  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-debug.zip
    29ea952cb4db8776e0b9250aed8653e309ea8824b4763853a86ef41d2912a3b99d  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-setup-unsigned.exe
    30b5f92fc5d319beacb8b5de4af8f9ed1da5e2465246f8f1f1496378cf1aa0a17d  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64-unsigned.tar.gz
    31abe11fca087679bd12c9e9beece5c1f5ffabc030efd1e74f33eb9ffe22072132  guix-build-f1df4dd2878a/output/x86_64-w64-mingw32/bitcoin-f1df4dd2878a-win64.zip
    
  6. in depends/packages/libxkbcommon.mk:15 in f1df4dd287 outdated
     7@@ -8,6 +8,7 @@ $(package)_dependencies=libxcb
     8 define $(package)_set_vars
     9 $(package)_config_opts = --enable-option-checking --disable-dependency-tracking
    10 $(package)_config_opts += --disable-static --disable-docs
    11+$(package)_cflags += -Wno-error=array-bounds
    


    laanwj commented at 7:36 am on June 23, 2022:
    Might want to add a comment here (e.g. that describes the work around and most importantly when it can go away)

    fanquake commented at 4:30 pm on June 23, 2022:
    I’ve added a comment that hopefully explains both.
  7. DrahtBot commented at 9:32 am on June 23, 2022: member

    Guix builds

    File commit 5884a47c367f6ff1aff3ae1ef6894881c5a5e0b7(master) commit c382169ed7cb42beff1b7057168a80aee56c28f1(master and this pull)
    SHA256SUMS.part 72e5a914ec12fe31... 0082f9d2df506e9a...
    *-aarch64-linux-gnu-debug.tar.gz 3f3d66875425c327... 044776c32044f2e0...
    *-aarch64-linux-gnu.tar.gz 4172e8c70cf307aa... 45bcce1caa9d150f...
    *-arm-linux-gnueabihf-debug.tar.gz 955f34d053c808ba... 00eae5ae4f49d5db...
    *-arm-linux-gnueabihf.tar.gz 46054fdb70630827... 9511276ab91612cf...
    *-arm64-apple-darwin-unsigned.dmg 8083222f1adba938... a411dddf075c74a0...
    *-arm64-apple-darwin-unsigned.tar.gz 5cbc26b80f01b426... eb61d58bcbf1ec4d...
    *-arm64-apple-darwin.tar.gz 81dfcabc0ea7bfd9... de498efcf549d71b...
    *-powerpc64-linux-gnu-debug.tar.gz 5b2c72ea065b2315... 6b45565ba1439db2...
    *-powerpc64-linux-gnu.tar.gz 3d34059ff2a4b372... dc61ffefae85c83d...
    *-powerpc64le-linux-gnu-debug.tar.gz d4c8cb081ab82ef2... e587b3de2cd1a777...
    *-powerpc64le-linux-gnu.tar.gz 4d9683362ca570a1... 9cc77bb2edb5de2e...
    *-riscv64-linux-gnu-debug.tar.gz ebd6636d6b54c69d... 430e06c58effdc4c...
    *-riscv64-linux-gnu.tar.gz 9c30c33e4c095c3d... 589a4d72c9a9eafc...
    *-win64-debug.zip 5aa41d31b872e127... de5a34e3886c6211...
    *-win64-setup-unsigned.exe c139a35251322bc1... 48664dd957ac335d...
    *-win64-unsigned.tar.gz 8411990550d8b55d... 24c170c90bc80f2d...
    *-win64.zip 0590f48d064ace10... 90d2595515ec48d4...
    *-x86_64-apple-darwin-unsigned.dmg b94f59a7de5a0ba5... 1bed3f4c085403f5...
    *-x86_64-apple-darwin-unsigned.tar.gz 64953822e080408b... 02cdf0be93e682d5...
    *-x86_64-apple-darwin.tar.gz 7e390aeb7b66d44b... 3f22d72214596b18...
    *-x86_64-linux-gnu-debug.tar.gz 974c7f24a340f7b5... c574007da7df2f7b...
    *-x86_64-linux-gnu.tar.gz d80b19091ecdc53a... 64d51483ade21b44...
    *.tar.gz 07404512520c48c4... d780bdb59111e2e5...
    guix_build.log acee27bb7fe296b5... 20a1e1eff035b5be...
    guix_build.log.diff 11e51f196e2caa7f...
  8. DrahtBot removed the label DrahtBot Guix build requested on Jun 23, 2022
  9. build: suppress array-bounds errors in libxkbcommon
    These occur when building with GCC 12.1.
    
    It might be the case that these would be suppressed by updating the
    package, but that would also require installing new build tools (meson),
    as well as potentially more dependencies (wayland).
    
    ```bash
    In function 'ExprCreateBoolean',
        inlined from 'BoolVarCreate' at src/xkbcomp/ast-build.c:316:19:
    src/xkbcomp/ast-build.c:119:23: error: array subscript 'ExprDef[0]' is partly outside array bounds of 'unsigned char[32]' [-Werror=array-bounds]
      119 |     expr->boolean.set = set;
          |     ~~~~~~~~~~~~~~~~~~^~~~~
    In function 'ExprCreate',
        inlined from 'ExprCreateBoolean' at src/xkbcomp/ast-build.c:118:5,
        inlined from 'BoolVarCreate' at src/xkbcomp/ast-build.c:316:19:
    src/xkbcomp/ast-build.c:75:21: note: object of size 32 allocated by 'malloc'
       75 |     ExprDef *expr = malloc(size);
          |                     ^~~~~~~~~~~~
    ```
    1bdbbbdc46
  10. build: use BOOST_NO_CXX98_FUNCTION_BASE to suppress warnings
    Boost conatiner_hash (included via functional -> multi_index) uses
    std::unary_function, which was deprecated in C++11, and "removed" in
    C++17. It's use causes wanrings with newer compilers, i.e GCC 12.1.
    
    ```bash
    /bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/container_hash/hash.hpp:131:33:
    warning: 'template<class _Arg, class _Result> struct std::unary_function' is deprecated [-Wdeprecated-declarations]
      131 |         struct hash_base : std::unary_function<T, std::size_t> {};
          |                                 ^~~~~~~~~~~~~~
    In file included from /usr/include/c++/12/bits/unique_ptr.h:37,
                     from /usr/include/c++/12/memory:76,
                     from ./init.h:10,
                     from init.cpp:10:
    /usr/include/c++/12/bits/stl_function.h:117:12: note: declared here
      117 |     struct unary_function
    ```
    
    Use the MACRO outlined in
    https://github.com/boostorg/container_hash/issues/22, to prevent it's
    use.
    
    BOOST_NO_CXX98_FUNCTION_BASE:
    > The standard library no longer supports std::unary_function and std::binary_function.
    > They were deprecated in C++11 and is removed from C++14.
    
    See:
    https://github.com/boostorg/config/pull/430
    https://en.cppreference.com/w/cpp/utility/functional/unary_function
    https://www.boost.org/doc/libs/master/libs/config/doc/html/boost_config/boost_macro_reference.html
    880d4aaf81
  11. fanquake force-pushed on Jun 23, 2022
  12. fanquake commented at 4:33 pm on June 23, 2022: member
    I’ve also played with updating the libxkbcommon package, which requires changing build systems (meson/ninja), there’s a work in progress branch here, https://github.com/fanquake/bitcoin/commit/adb123d84b33f1eadfa416d28b2f3b093678b10e, but it doesn’t yet work properly. If someone wanted to play with that, they could, but I also don’t think we should block building depends with GCC 12 on updating libxkbcommon.
  13. DrahtBot commented at 3:06 am on June 24, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24283 (build: Add show-% target for multi-line variables and debug info by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  14. laanwj commented at 9:03 am on June 27, 2022: member
    This is fine imo. I mean we only use libxkbcommon to link against, it doesn’t really matter what the version is (older is better, probably, from a compat point of view).
  15. laanwj commented at 9:09 am on June 27, 2022: member
    Code review ACK 880d4aaf81f3d5d7fbb915905c2e61b816a6a747
  16. laanwj merged this on Jun 27, 2022
  17. laanwj closed this on Jun 27, 2022

  18. fanquake deleted the branch on Jun 27, 2022
  19. sidhujag referenced this in commit a1b0e8fc83 on Jun 27, 2022
  20. knst referenced this in commit d10ac28d7c on Oct 25, 2022
  21. PastaPastaPasta referenced this in commit 4fde6a8f71 on Nov 2, 2022
  22. fanquake referenced this in commit 2b211b41e3 on Jan 31, 2023
  23. sidhujag referenced this in commit 38923405aa on Jan 31, 2023
  24. fanquake referenced this in commit ec7a8839a2 on Apr 17, 2023
  25. fanquake referenced this in commit 7b7636ead1 on May 1, 2023
  26. DrahtBot locked this on Jun 27, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me