These methods haven't been used since the chainstate db cache has been
switched from per-tx to per-txout model years ago (PR #10195, commit
d342424301013ec47dc146a4beb49d5c9319d80a).
fb38c6e21f
DrahtBot added the label
Refactoring
on Jun 21, 2022
DrahtBot added the label
UTXO Db and Indexes
on Jun 21, 2022
w0xlt approved
w0xlt
commented at 5:15 pm on June 21, 2022:
contributor
furszy
commented at 6:32 pm on June 22, 2022:
member
ACKfb38c6e2
furszy
commented at 6:40 pm on June 22, 2022:
member
Btw, checking at this dbwrapper.h file, isn’t CompactRange unused as well?
laanwj
commented at 8:35 am on June 23, 2022:
member
Btw, checking at this dbwrapper.h file, isn’t CompactRange unused as well?
Yes. It seems like it!
A direct call to leveldb’s CompactRange is used in CDBWrapper::CDBWrapper in -forcecompactdb handling. But our own function is never used.
The last use went away in #22626.
This method hasn't been used since the txindex migration code has been
removed (PR #22626, commit fa20f815a9cb438c5ab61e97a453612ddd8b21b5).
Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
e4b4db5610
theStack renamed this:
refactor: remove unused methods `{CDBIterator,CCoinsViewDBCursor}::GetValueSize()`
refactor: remove unused methods in classes `CDBIterator,CCoinsViewDBCursor`
on Jun 23, 2022
theStack
commented at 12:09 pm on June 23, 2022:
member
@furszy@laanwj: Thanks a lot, good catch! Added another commit and updated the PR title / description accordingly.
fanquake approved
fanquake
commented at 12:10 pm on June 23, 2022:
member
ACKe4b4db561049c97c956e5b856713dcf63ac3e2f0
theStack renamed this:
refactor: remove unused methods in classes `CDBIterator,CCoinsViewDBCursor`
refactor: remove unused methods in classes `CDBIterator,CDBWrapper,CCoinsViewDBCursor`
on Jun 23, 2022
furszy approved
furszy
commented at 12:31 pm on June 23, 2022:
member
re-ACKe4b4db56
MarcoFalke
commented at 12:52 pm on June 23, 2022:
member
0txdb.cpp:154:19: error: no member named 'Clear' in 'CDBBatch'
1 batch.Clear();
2 ~~~~~ ^
31 error generated.
4gmake[2]: *** [Makefile:10066: libbitcoin_node_a-txdb.o] Error 1
DrahtBot
commented at 3:02 pm on June 23, 2022:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#25296 (Add DataStream without ser-type and ser-version and use it where possible by MarcoFalke)
#24232 (assumeutxo: add init and completion logic by jamesob)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj approved
laanwj
commented at 5:51 pm on June 23, 2022:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me