p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters #25446

1. 
   dergoegge commented at 9:16 am on June 22, 2022: member

   This line was accidentally removed in #22778.

   Receiving a filterload message implies that we should relay txs to the sender (CNode::m_relays_txs = true). CNode::m_relays_txs is only used for the inbound eviction logic, so removing the line might have slightly changed the eviction behaviour but nothing else.

2. [net processing] Set CNode::m_relays_txs=true when receiving BIP37 filters

   This line was accidentally removed in #22778.

   e7a9133766
3. fanquake added the label P2P on Jun 22, 2022
4. dergoegge renamed this:
   [net processing] Set CNode::m_relays_txs=true when receiving BIP37 filters
   p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters
   on Jun 22, 2022
5. 
   laanwj commented at 11:32 am on June 22, 2022: member

   I see, it was removed here: https://github.com/bitcoin/bitcoin/pull/22778/files#diff-6875de769e90cec84d2e8a9c1b962cdbcda44d870d42e4215827e599e11e90e3R4090

   Code review ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

6. vasild approved
7. 
   vasild commented at 12:13 pm on June 22, 2022: member

   ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

   So it actually happened that the redundant fields CNode::m_relays_txs and Peer::TxRelay::m_relay_txs went out of sync (one is true while the other is false) :-(

8. 
   DrahtBot commented at 5:25 pm on June 22, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25268 (refactor: Introduce EvictionManager by dergoegge)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. fanquake merged this on Jun 23, 2022
10. fanquake closed this on Jun 23, 2022

    ---

11. sidhujag referenced this in commit 4c520d1677 on Jun 27, 2022
12. 
    jnewbery commented at 8:27 am on June 29, 2022: member

    post-merge ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

    Thanks @dergoegge!

13. DrahtBot locked this on Jun 29, 2023

Contributors
dergoegge laanwj vasild DrahtBot jnewbery

Labels
P2P