Bugfix: Do not define HAVE_O_CLOEXEC for LevelDB when O_CLOEXEC is not available #25463

1. 
   luke-jr commented at 5:19 am on June 24, 2022: member

   LevelDB uses #ifdef for HAVE_O_CLOEXEC, so if not available, it needs to be not-defined
2. Bugfix: Do not define HAVE_O_CLOEXEC for LevelDB when O_CLOEXEC is not available

   LevelDB uses #ifdef for HAVE_O_CLOEXEC, so if not available, it needs to be not-defined

   a956806de2
3. DrahtBot added the label Build system on Jun 24, 2022
4. 
   hebasto commented at 7:07 am on June 24, 2022: member

   Why not https://github.com/google/leveldb/pull/1028?
5. 
   luke-jr commented at 6:42 pm on June 24, 2022: member

   That’s ideal, but not merged yet, and even if it’s done in time for 24.x, we should still fix it here now for backports.
6. 
   hebasto commented at 7:11 pm on June 24, 2022: member

   That’s ideal, but not merged yet…

   Maybe pick that commit into our subtree?

7. 
   laanwj commented at 2:33 pm on June 25, 2022: member

   I’d also prefer cherry-picking the leveldb change instead.
8. 
   fanquake commented at 9:18 am on June 27, 2022: member

   I’d also prefer cherry-picking the leveldb change instead.

   Agree with this as well.

9. 
   DrahtBot commented at 12:18 pm on June 29, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

10. 
    hebasto commented at 12:43 pm on June 29, 2022: member

    I’d also prefer cherry-picking the leveldb change instead.

    Agree with this as well.

    https://github.com/bitcoin-core/leveldb-subtree/pull/32

11. 
    fanquake commented at 8:44 am on July 20, 2022: member

    That’s ideal, but not merged yet,

    Given https://github.com/google/leveldb/commit/7b650f85de0b785596cc145a3dd28a54cb73bb50, I’d say the likelyhood of it being merged upstream is very low, so it being merged upstream shouldn’t be a blocker for cherry-picking into our subtree and pulling it down here if we want.

12. fanquake referenced this in commit 22f1e4a02f on Jul 27, 2022
13. 
    fanquake commented at 8:57 am on July 27, 2022: member

    https://github.com/bitcoin-core/leveldb-subtree/pull/32 has been merged into our subtree.
14. 
    fanquake commented at 1:48 pm on July 29, 2022: member

    Opened a subtree update that pulls in https://github.com/bitcoin-core/leveldb-subtree/pull/32 in #25739.
15. 
    luke-jr commented at 3:37 pm on July 29, 2022: member

    Closing in favour of #25739
16. luke-jr closed this on Jul 29, 2022

    ---

17. fanquake referenced this in commit 28be13ec99 on Aug 1, 2022
18. sidhujag referenced this in commit 94daf53cf0 on Aug 1, 2022
19. UdjinM6 referenced this in commit d62e5d9324 on Sep 9, 2022
20. PastaPastaPasta referenced this in commit 3e9d136b3a on Sep 23, 2022
21. PastaPastaPasta referenced this in commit 8efd7f04c6 on Sep 29, 2022
22. michael-EA referenced this in commit 60fab518b6 on Oct 22, 2022
23. bitcoin locked this on Jul 29, 2023

Contributors
luke-jr hebasto laanwj fanquake DrahtBot

Labels
Build system