LevelDB uses #ifdef for HAVE_O_CLOEXEC, so if not available, it needs to be not-defined
Bugfix: Do not define HAVE_O_CLOEXEC for LevelDB when O_CLOEXEC is not available #25463
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_leveldb_no_cloexec changing 2 files +5 −1-
luke-jr commented at 5:19 AM on June 24, 2022: member
-
a956806de2
Bugfix: Do not define HAVE_O_CLOEXEC for LevelDB when O_CLOEXEC is not available
LevelDB uses #ifdef for HAVE_O_CLOEXEC, so if not available, it needs to be not-defined
- DrahtBot added the label Build system on Jun 24, 2022
-
hebasto commented at 7:07 AM on June 24, 2022: member
-
luke-jr commented at 6:42 PM on June 24, 2022: member
That's ideal, but not merged yet, and even if it's done in time for 24.x, we should still fix it here now for backports.
-
hebasto commented at 7:11 PM on June 24, 2022: member
That's ideal, but not merged yet...
Maybe pick that commit into our subtree?
-
laanwj commented at 2:33 PM on June 25, 2022: member
I'd also prefer cherry-picking the leveldb change instead.
-
fanquake commented at 9:18 AM on June 27, 2022: member
I'd also prefer cherry-picking the leveldb change instead.
Agree with this as well.
-
DrahtBot commented at 12:18 PM on June 29, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
hebasto commented at 12:43 PM on June 29, 2022: member
I'd also prefer cherry-picking the leveldb change instead.
Agree with this as well.
-
fanquake commented at 8:44 AM on July 20, 2022: member
That's ideal, but not merged yet,
Given https://github.com/google/leveldb/commit/7b650f85de0b785596cc145a3dd28a54cb73bb50, I'd say the likelyhood of it being merged upstream is very low, so it being merged upstream shouldn't be a blocker for cherry-picking into our subtree and pulling it down here if we want.
- fanquake referenced this in commit 22f1e4a02f on Jul 27, 2022
-
fanquake commented at 8:57 AM on July 27, 2022: member
https://github.com/bitcoin-core/leveldb-subtree/pull/32 has been merged into our subtree.
-
fanquake commented at 1:48 PM on July 29, 2022: member
Opened a subtree update that pulls in https://github.com/bitcoin-core/leveldb-subtree/pull/32 in #25739.
-
- luke-jr closed this on Jul 29, 2022
- fanquake referenced this in commit 28be13ec99 on Aug 1, 2022
- sidhujag referenced this in commit 94daf53cf0 on Aug 1, 2022
- UdjinM6 referenced this in commit d62e5d9324 on Sep 9, 2022
- PastaPastaPasta referenced this in commit 3e9d136b3a on Sep 23, 2022
- PastaPastaPasta referenced this in commit 8efd7f04c6 on Sep 29, 2022
- michael-EA referenced this in commit 60fab518b6 on Oct 22, 2022
- bitcoin locked this on Jul 29, 2023
Labels