remove obsolete and unused typedef for Windows #2552

Diapolo commented at 7:56 AM on April 23, 2013: none

No description provided.

remove obsolete and unused typedef for Windows 61032f8942

laanwj commented at 8:06 AM on April 23, 2013: member

Let's see if gitian/pull tester agrees with this being deprecated :)

BitcoinPullTester commented at 8:12 AM on April 23, 2013: none

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/61032f894247f7a4158ec5b41067bcd7c3f35910 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Diapolo commented at 8:19 AM on April 23, 2013: none

@laanwj Seems that one is caused by @BitcoinPullTester ^^, I hope Matt can take a look.

TheBlueMatt commented at 1:45 PM on April 23, 2013: member

Oops, false-positive, sorry, retesting...

Diapolo commented at 1:59 PM on April 25, 2013: none

@TheBlueMatt It's still not building it seems?

TheBlueMatt commented at 6:54 PM on April 25, 2013: member

Yep, sorry...pull-tester is now undergoing upgrades to handle new dependencies for payment protocol...

BitcoinPullTester commented at 9:25 PM on April 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/61032f894247f7a4158ec5b41067bcd7c3f35910 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj commented at 12:55 PM on April 27, 2013: member

Maybe this is needed for MSVC? I really wonder why we added this...

Diapolo commented at 3:25 PM on April 27, 2013: none

I'm not aware of anyone doing MSVC builds recently. I'll take a look what commit added this. Edit: Damn ^^ https://github.com/bitcoin/bitcoin/commit/efdcf941742cb63b441656241d6699ac8d2819d3

Diapolo commented at 5:44 PM on May 3, 2013: none

Anyone?

jgarzik referenced this in commit 3fbd87e0dc on May 30, 2013

jgarzik merged this on May 30, 2013

jgarzik closed this on May 30, 2013

ghost commented at 10:46 AM on June 10, 2013: none

This commit breaks cross-compiling Windows client from Linux:

i686-w64-mingw32-g++ -c -pipe -isystem /usr/i686-w64-mingw32/include/ -frandom-seed=qtbuild -D_FORTIFY_SOURCE=2 -msse2 -O2 -frtti -fexceptions -fdiagnostics-show-option -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wstack-protector -DBOOST_THREAD_USE_LIB -DBOOST_THREAD_USE_LIB -DBOOST_SPIRIT_THREADSAFE -DSCRYPT_CHACHA -DSCRYPT_KECCAK512 -DUSE_UPNP=1 -DSTATICLIB -DUSE_IPV6=1 -DBITCOIN_NEED_QT_PLUGINS -DHAVE_BUILD_INFO -DWIN32 -D_MT -DQT_THREAD_SUPPORT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I'../deps/qt/include/QtCore' -I'../deps/qt/include/QtNetwork' -I'../deps/qt/include/QtGui' -I'../deps/qt/include' -I'../deps' -I'src' -I'src/json' -I'src/qt' -I'../deps' -I'src/leveldb/include' -I'src/leveldb/helpers' -I'../deps/boost_1_53_0' -I'../deps/db-5.3.21.NC/build_unix' -I'../deps/openssl-1.0.1e/include' -I'../deps/qt/include/ActiveQt' -I'build' -I'build' -I'../deps/qt/mkspecs/unsupported/win32-g++-cross' -o build/bitcoin.o src/qt/bitcoin.cpp
In file included from ../deps/boost_1_53_0/boost/thread/shared_mutex.hpp:18:0,
                 from ../deps/boost_1_53_0/boost/thread/detail/thread_group.hpp:9,
                 from ../deps/boost_1_53_0/boost/thread/thread.hpp:26,
                 from ../deps/boost_1_53_0/boost/thread.hpp:13,
                 from src/util.h:23,
                 from src/bignum.h:12,
                 from src/main.h:8,
                 from src/wallet.h:13,
                 from src/init.h:8,
                 from src/qt/bitcoin.cpp:13:
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp: In constructor ‘boost::shared_mutex::shared_mutex()’:
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member ‘boost::shared_mutex::state_data::shared_waiting’ [-Wmissing-field-initializers]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member ‘boost::shared_mutex::state_data::exclusive’ [-Wmissing-field-initializers]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member ‘boost::shared_mutex::state_data::upgrade’ [-Wmissing-field-initializers]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member ‘boost::shared_mutex::state_data::exclusive_waiting’ [-Wmissing-field-initializers]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member ‘boost::shared_mutex::state_data::exclusive_waiting_blocked’ [-Wmissing-field-initializers]
In file included from src/bignum.h:12:0,
                 from src/main.h:8,
                 from src/wallet.h:13,
                 from src/init.h:8,
                 from src/qt/bitcoin.cpp:13:
src/util.h: At global scope:
src/util.h:220:57: error: ‘pid_t’ has not been declared
In file included from ../deps/boost_1_53_0/boost/thread/shared_mutex.hpp:18:0,
                 from ../deps/boost_1_53_0/boost/thread/detail/thread_group.hpp:9,
                 from ../deps/boost_1_53_0/boost/thread/thread.hpp:26,
                 from ../deps/boost_1_53_0/boost/thread.hpp:13,
                 from src/util.h:23,
                 from src/bignum.h:12,
                 from src/main.h:8,
                 from src/wallet.h:13,
                 from src/init.h:8,
                 from src/qt/bitcoin.cpp:13:
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp: In member function ‘T boost::shared_mutex::interlocked_compare_exchange(T*, T, T) [with T = boost::shared_mutex::state_data]’:
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:124:103:   instantiated from here
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:52:99: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:52:99: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:53:52: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
../deps/boost_1_53_0/boost/thread/win32/shared_mutex.hpp:53:52: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
../deps/boost_1_53_0/boost/system/error_code.hpp: At global scope:
../deps/boost_1_53_0/boost/system/error_code.hpp:214:36: warning: ‘boost::system::posix_category’ defined but not used [-Wunused-variable]
../deps/boost_1_53_0/boost/system/error_code.hpp:215:36: warning: ‘boost::system::errno_ecat’ defined but not used [-Wunused-variable]
../deps/boost_1_53_0/boost/system/error_code.hpp:216:36: warning: ‘boost::system::native_ecat’ defined but not used [-Wunused-variable]
make[1]: *** [build/bitcoin.o] Error 1
make[1]: Leaving directory `/home/creator/code/onecoin-builder/onecoin'
make: *** [release] Error 2

DrahtBot locked this on Sep 8, 2021