gui: Check for readlink buffer overflow and handle gracefully #25548

1. 
   luke-jr commented at 11:45 pm on July 5, 2022: member

   If readlink returns the size of the buffer, an overflow may have (safely) occurred. Pass a buffer size of MAX_PATH+1 (the size of the actual buffer) to detect this scenario.
2. Bugfix: Check for readlink buffer overflow and handle gracefully

   If readlink returns the size of the buffer, an overflow may have (safely) occurred.
   Pass a buffer size of MAX_PATH+1 (the size of the actual buffer) to detect this scenario.

   e049fd76f0
3. maflcko added the label GUI on Jul 6, 2022
4. maflcko renamed this:
   Bugfix: Check for readlink buffer overflow and handle gracefully
   gui: Check for readlink buffer overflow and handle gracefully
   on Jul 6, 2022
5. maflcko added the label Bug on Jul 6, 2022
6. 
   DrahtBot commented at 11:08 am on September 23, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

7. 
   fanquake commented at 4:13 pm on October 2, 2022: member

   @hebasto
8. hebasto approved
9. 
   hebasto commented at 10:37 am on October 5, 2022: member

   ACK e049fd76f0d57c1e6400fbfbaf4cc6ebe540f16f.

   From man -s 2 readlink on my Ubuntu 22.04:

   If the returned value equals bufsiz, then truncation may have occurred.

10. fanquake merged this on Nov 1, 2022
11. fanquake closed this on Nov 1, 2022

    ---

12. 
    fanquake commented at 12:20 pm on November 1, 2022: member

    Backported to 24.x in #26434.
13. fanquake referenced this in commit 067dc42b79 on Nov 1, 2022
14. sidhujag referenced this in commit 95cb211084 on Nov 1, 2022
15. bitcoin locked this on Nov 1, 2023

Contributors
luke-jr DrahtBot fanquake hebasto

Labels
Bug GUI