move-only: Version handshake to libtest_util #25591

1. 
   MarcoFalke commented at 6:45 am on July 12, 2022: member

   The version handshake after setting up a peer is an integral part of (unit) testing net processing logic.

   Thus, make the helper accessible in libtest_util.

   Also, remove the peerman argument from FillNode, as it must be equal to connman’s peerman, which can then be used instead.

2. move-only: Version handshake to libtest_util fa7098947c
3. move-only: InitializeNode to handshake helper fa4be8e7c3
4. MarcoFalke added the label Refactoring on Jul 12, 2022
5. MarcoFalke added the label Tests on Jul 12, 2022
6. 
   DrahtBot commented at 7:44 am on July 12, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25515 ([draft] PeerManager unit tests by dergoegge)
   • #25514 (net processing: Move CNode::nServices and CNode::nLocalServices to Peer by dergoegge)
   • #25284 ([WIP] consensus: Remove dependency on net (BIP 155 / ADDRV2_FORMAT) by MarcoFalke)
   • #24170 (p2p, rpc: Manual block-relay-only connections with addnode by mzumsande)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   dergoegge commented at 2:55 pm on July 12, 2022: member

   ACK fa4be8e7c324835d3b9eecb5a3825a4c8f77fb2f
8. MarcoFalke merged this on Jul 12, 2022
9. MarcoFalke closed this on Jul 12, 2022

   ---

10. MarcoFalke deleted the branch on Jul 12, 2022
11. sidhujag referenced this in commit ca188c8109 on Jul 12, 2022
12. fanquake deleted a comment on Jul 13, 2022
13. MarcoFalke locked this on Jul 13, 2022

Contributors
MarcoFalke DrahtBot dergoegge

Labels
Refactoring Tests