It seems that it's time for our experiment with this file to come to an end.
See discussion here: https://github.com/bitcoin/bitcoin/pull/25560/files#r915491743.
doc: empty REVIEWERS file #25613
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_reviewers changing 1 files +0 −123-
fanquake commented at 12:28 PM on July 14, 2022: member
- fanquake added the label Docs on Jul 14, 2022
- kristapsk approved
-
kristapsk commented at 12:33 PM on July 14, 2022: contributor
ACK cdbc68c1cd9b8228f8cdee9f61c20639325fb67d. It's kinda CODEOWNERS, don't think Bitcoin Core should have such thing.
-
Sjors commented at 1:50 PM on July 14, 2022: member
No strong preference. I usually look at git blame if I feel the need to nag more reviewers.
-
MarcoFalke commented at 2:01 PM on July 14, 2022: member
Yes,
git blameis best if you want to manually find reviewers.However, this list was made for people to opt-in to bot notifications (as it is explained in the first line of the file), but then some people on the list complained about being notified by a bot. :man_shrugging:
If there is anyone in this list who prefers those bot notifications, I think we should keep them in this list and remove everyone else.
-
MarcoFalke commented at 2:31 PM on July 14, 2022: member
Currently, the format of the comment looks like this: #25614 (comment)
This may be interesting to people that are not subscribed to the repo, but want to subscribe to changes to a specific file or folder.
My suggestion would be to keep the file and remove all contents for now, then leave the pull open for two weeks before merge. In those two weeks, people can explicitly opt-in by leaving a comment to be (re-)added to the file with the understanding that they will receive some kind of bot notifications. Also, anyone can open a pull request in the future to opt-in.
-
DrahtBot commented at 7:02 PM on July 14, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
fanquake commented at 7:56 AM on July 30, 2022: member
My suggestion would be to keep the file and remove all contents for now, then leave the pull open for two weeks before merge. In those two weeks, people can explicitly opt-in by leaving a comment to be (re-)added to the file with the understanding that they will receive some kind of bot notifications.
Should we wait any longer?
-
MarcoFalke commented at 8:02 AM on July 30, 2022: member
I'd also say to keep the empty file in the repo for another two months to give people a chance to add themselves (opt-in to notifications) if they want.
-
4d06fc4bed
doc: empty REVIEWERS file
It seems that it's time for our experiment with this file to come to an end. See discussion here: https://github.com/bitcoin/bitcoin/pull/25560/files#r915491743.
- fanquake force-pushed on Jul 30, 2022
-
fanquake commented at 8:06 AM on July 30, 2022: member
I'd also say to keep the empty file in the repo
Pushed to just empty the file.
-
MarcoFalke commented at 8:07 AM on July 30, 2022: member
ACK 4d06fc4bed12ca119208ee53369719f52b0f7098 seems best to have devs opt-in to this explicitly by themselves
- MarcoFalke renamed this:
doc: remove REVIEWERS
doc: empty REVIEWERS file
on Aug 1, 2022 - MarcoFalke merged this on Aug 1, 2022
- MarcoFalke closed this on Aug 1, 2022
- fanquake deleted the branch on Aug 1, 2022
- sidhujag referenced this in commit 52f531f3eb on Aug 1, 2022
- MarcoFalke locked this on Feb 10, 2023
