build: Add `double_conversion` package for Linux hosts

hebasto commented at 9:29 pm on July 18, 2022: member

A continuation of previous steps wrt bitcoin/bitcoin#21194.

Guix builds:

on x86_64:

 0db928383b62b6c27a273152381ba859d58f2b20bf806e23bd163c34d916ae48e  guix-build-2a90059993b3/output/aarch64-linux-gnu/SHA256SUMS.part
 11937aaa9a6b4ac8e2b6edeabf782ace7225b7abdb7242db546dad2510c139c05  guix-build-2a90059993b3/output/aarch64-linux-gnu/bitcoin-2a90059993b3-aarch64-linux-gnu-debug.tar.gz
 26bd972593bf302d1c61928504a8cf299f82d6c643e3c645645233307b1643b4a  guix-build-2a90059993b3/output/aarch64-linux-gnu/bitcoin-2a90059993b3-aarch64-linux-gnu.tar.gz
 348ba553b14c47b8cd5334eb4b53b5976d8b6dbd5ea99cc9f1810c98751a84c78  guix-build-2a90059993b3/output/arm-linux-gnueabihf/SHA256SUMS.part
 4b645e68d72511b0a739c2fcae512f31c6126adb43aa667d9bf325ba224d6fa9e  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf-debug.tar.gz
 5cb2d9daf64014521fd491d6cfde151247d5ce26fcc02c048a0b87cc02a4efc35  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf.tar.gz
 6f2e174c50b82b64c32e5e8b129c3d2060884ea1acd2e954fab65eb95658fa9a4  guix-build-2a90059993b3/output/arm64-apple-darwin/SHA256SUMS.part
 7288c5e306996f3dfbc3b4bd2681ec0faaa91e2c61b0bd14eefd0f4a0e8634a06  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.dmg
 885c63680ac7fe5a2ac52a400d995817ac7480fb1868fff9484b036f691ce312f  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.tar.gz
 9cadd5b0e7c06db2856aecc10729af139969e9f36ba1a6ba26018a2e95d8348d2  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin.tar.gz
10a1172451dd685751c4d8be22109c9f363661e46e055ca42bee3aab9bd341cf56  guix-build-2a90059993b3/output/dist-archive/bitcoin-2a90059993b3.tar.gz
110009ca4894c1e1432456b1e7043546ebd8f1333d8e6c69c1f894ba7023df3cff  guix-build-2a90059993b3/output/powerpc64-linux-gnu/SHA256SUMS.part
12b60539f7fd8ff07ac624eac090de86775552e6c58e760b21f0b2164de8c11cb2  guix-build-2a90059993b3/output/powerpc64-linux-gnu/bitcoin-2a90059993b3-powerpc64-linux-gnu-debug.tar.gz
13053c821c9e55c8003ec6cdb90350cbbd167c2a8eb39f53a58ca3231be15aa4bf  guix-build-2a90059993b3/output/powerpc64-linux-gnu/bitcoin-2a90059993b3-powerpc64-linux-gnu.tar.gz
14ed7a9a1fdf38c5b241db3a6a8899bab304c524b8acaac9b2a6d5d7cb5f08ad1c  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/SHA256SUMS.part
15f84323706499d13fa5f7baf9b68dbd02b3a52ca9d0957bf4cc919c0191c51582  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/bitcoin-2a90059993b3-powerpc64le-linux-gnu-debug.tar.gz
1651486c8ef58ab8efb2bfe51621806136bd5fcfbe0d7af61baeea71f685ea6912  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/bitcoin-2a90059993b3-powerpc64le-linux-gnu.tar.gz
17bb08a6349d34cdcdd3efb48e7a3c5bbad3005ba9286021d5a5c51605d241d879  guix-build-2a90059993b3/output/riscv64-linux-gnu/SHA256SUMS.part
18e899ddd1cf5fb137837772910fb3ac518aa204965dc271b3ad48713c9bd93e5d  guix-build-2a90059993b3/output/riscv64-linux-gnu/bitcoin-2a90059993b3-riscv64-linux-gnu-debug.tar.gz
19262f61b8f1d8346372a98ee86e60b0df6e9ae07100d32afbc4fb78fc1d065444  guix-build-2a90059993b3/output/riscv64-linux-gnu/bitcoin-2a90059993b3-riscv64-linux-gnu.tar.gz
2008a25e57de58b4b7b47b607eefa2da17ded5acdbf4d035af1f2324b7c9d99893  guix-build-2a90059993b3/output/x86_64-apple-darwin/SHA256SUMS.part
21363d7fbd3f455743abc6c838ccc3fede7aa2b05d2e393546852f4e1907ac3d60  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin-unsigned.dmg
2299904773b72e3e0887647ed85e5872124a023f8aa8a78145b39f28103ce00b15  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin-unsigned.tar.gz
234317d12715c50ffa6d8a019087535e6ff4551b635f140c9f0df9fce7cdcf8f3e  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin.tar.gz
24f58ac28d3b4a7d5c1209c14cb3b59ac9231a401572d18b3a681904ad78857c89  guix-build-2a90059993b3/output/x86_64-linux-gnu/SHA256SUMS.part
25cffdc08821a2e465ba2023a88a1e5032645e3e88dd9f28c312cf7bdd10c51135  guix-build-2a90059993b3/output/x86_64-linux-gnu/bitcoin-2a90059993b3-x86_64-linux-gnu-debug.tar.gz
265712c6ba2fbecdd770db2083b811ce3d15c0b0bfd4b6ec8c51e2174acc27b61c  guix-build-2a90059993b3/output/x86_64-linux-gnu/bitcoin-2a90059993b3-x86_64-linux-gnu.tar.gz
27bd2517e597ed56097e13f9bfe1f8f3454e505b287af23b2c03ca2dfef32157dd  guix-build-2a90059993b3/output/x86_64-w64-mingw32/SHA256SUMS.part
28616f612d8dee54229ccab0366046d274b4ccc3a766d0f2979819070499c27272  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-debug.zip
296599d0f913cc78cdfde9928737a9c3e58dbce07e1958172533faa61d8910da62  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-setup-unsigned.exe
30f30d587b1fc604cf1a5b975d8653f9abd66af0a1f298a614a96e9b12c3cfa9e1  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-unsigned.tar.gz
3199bc39b1dda413b0cf853d26e3de3071bebaea6efe7a6ec3ff43ec8508aad906  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64.zip

on arm64:

 048ba553b14c47b8cd5334eb4b53b5976d8b6dbd5ea99cc9f1810c98751a84c78  guix-build-2a90059993b3/output/arm-linux-gnueabihf/SHA256SUMS.part
 1b645e68d72511b0a739c2fcae512f31c6126adb43aa667d9bf325ba224d6fa9e  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf-debug.tar.gz
 2cb2d9daf64014521fd491d6cfde151247d5ce26fcc02c048a0b87cc02a4efc35  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf.tar.gz
 316bb9b4e714b3cdd1b9639769c933f4a2800d91b059a497eee4d063cf9fa8424  guix-build-2a90059993b3/output/arm64-apple-darwin/SHA256SUMS.part
 4240016945b021cb1826417cba1055ecc38a3e52d5c0326bd532e939afd816827  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.dmg
 57542ae436ecd75f260a181807cd424c0fc0596208332dd9e58e1e48c2fa01638  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.tar.gz
 6c65723400bc1644210c8311bb41a81c2698ac219e233790b9bb361d9cdc23cd4  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin.tar.gz
 7a1172451dd685751c4d8be22109c9f363661e46e055ca42bee3aab9bd341cf56  guix-build-2a90059993b3/output/dist-archive/bitcoin-2a90059993b3.tar.gz
 80009ca4894c1e1432456b1e7043546ebd8f1333d8e6c69c1f894ba7023df3cff  guix-build-2a90059993b3/output/powerpc64-linux-gnu/SHA256SUMS.part
 9b60539f7fd8ff07ac624eac090de86775552e6c58e760b21f0b2164de8c11cb2  guix-build-2a90059993b3/output/powerpc64-linux-gnu/bitcoin-2a90059993b3-powerpc64-linux-gnu-debug.tar.gz
10053c821c9e55c8003ec6cdb90350cbbd167c2a8eb39f53a58ca3231be15aa4bf  guix-build-2a90059993b3/output/powerpc64-linux-gnu/bitcoin-2a90059993b3-powerpc64-linux-gnu.tar.gz
11ed7a9a1fdf38c5b241db3a6a8899bab304c524b8acaac9b2a6d5d7cb5f08ad1c  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/SHA256SUMS.part
12f84323706499d13fa5f7baf9b68dbd02b3a52ca9d0957bf4cc919c0191c51582  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/bitcoin-2a90059993b3-powerpc64le-linux-gnu-debug.tar.gz
1351486c8ef58ab8efb2bfe51621806136bd5fcfbe0d7af61baeea71f685ea6912  guix-build-2a90059993b3/output/powerpc64le-linux-gnu/bitcoin-2a90059993b3-powerpc64le-linux-gnu.tar.gz
14bb08a6349d34cdcdd3efb48e7a3c5bbad3005ba9286021d5a5c51605d241d879  guix-build-2a90059993b3/output/riscv64-linux-gnu/SHA256SUMS.part
15e899ddd1cf5fb137837772910fb3ac518aa204965dc271b3ad48713c9bd93e5d  guix-build-2a90059993b3/output/riscv64-linux-gnu/bitcoin-2a90059993b3-riscv64-linux-gnu-debug.tar.gz
16262f61b8f1d8346372a98ee86e60b0df6e9ae07100d32afbc4fb78fc1d065444  guix-build-2a90059993b3/output/riscv64-linux-gnu/bitcoin-2a90059993b3-riscv64-linux-gnu.tar.gz
1708a25e57de58b4b7b47b607eefa2da17ded5acdbf4d035af1f2324b7c9d99893  guix-build-2a90059993b3/output/x86_64-apple-darwin/SHA256SUMS.part
18363d7fbd3f455743abc6c838ccc3fede7aa2b05d2e393546852f4e1907ac3d60  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin-unsigned.dmg
1999904773b72e3e0887647ed85e5872124a023f8aa8a78145b39f28103ce00b15  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin-unsigned.tar.gz
204317d12715c50ffa6d8a019087535e6ff4551b635f140c9f0df9fce7cdcf8f3e  guix-build-2a90059993b3/output/x86_64-apple-darwin/bitcoin-2a90059993b3-x86_64-apple-darwin.tar.gz
21f58ac28d3b4a7d5c1209c14cb3b59ac9231a401572d18b3a681904ad78857c89  guix-build-2a90059993b3/output/x86_64-linux-gnu/SHA256SUMS.part
22cffdc08821a2e465ba2023a88a1e5032645e3e88dd9f28c312cf7bdd10c51135  guix-build-2a90059993b3/output/x86_64-linux-gnu/bitcoin-2a90059993b3-x86_64-linux-gnu-debug.tar.gz
235712c6ba2fbecdd770db2083b811ce3d15c0b0bfd4b6ec8c51e2174acc27b61c  guix-build-2a90059993b3/output/x86_64-linux-gnu/bitcoin-2a90059993b3-x86_64-linux-gnu.tar.gz
24bd2517e597ed56097e13f9bfe1f8f3454e505b287af23b2c03ca2dfef32157dd  guix-build-2a90059993b3/output/x86_64-w64-mingw32/SHA256SUMS.part
25616f612d8dee54229ccab0366046d274b4ccc3a766d0f2979819070499c27272  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-debug.zip
266599d0f913cc78cdfde9928737a9c3e58dbce07e1958172533faa61d8910da62  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-setup-unsigned.exe
27f30d587b1fc604cf1a5b975d8653f9abd66af0a1f298a614a96e9b12c3cfa9e1  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64-unsigned.tar.gz
2899bc39b1dda413b0cf853d26e3de3071bebaea6efe7a6ec3ff43ec8508aad906  guix-build-2a90059993b3/output/x86_64-w64-mingw32/bitcoin-2a90059993b3-win64.zip

Please note the diff

 0--- x86_64	2022-07-19 10:15:31.475389130 +0100
 1+++ arm64	2022-07-19 10:15:51.387233404 +0100
 2@@ -1,13 +1,10 @@
 3-db928383b62b6c27a273152381ba859d58f2b20bf806e23bd163c34d916ae48e  guix-build-2a90059993b3/output/aarch64-linux-gnu/SHA256SUMS.part
 4-1937aaa9a6b4ac8e2b6edeabf782ace7225b7abdb7242db546dad2510c139c05  guix-build-2a90059993b3/output/aarch64-linux-gnu/bitcoin-2a90059993b3-aarch64-linux-gnu-debug.tar.gz
 5-6bd972593bf302d1c61928504a8cf299f82d6c643e3c645645233307b1643b4a  guix-build-2a90059993b3/output/aarch64-linux-gnu/bitcoin-2a90059993b3-aarch64-linux-gnu.tar.gz
 6 48ba553b14c47b8cd5334eb4b53b5976d8b6dbd5ea99cc9f1810c98751a84c78  guix-build-2a90059993b3/output/arm-linux-gnueabihf/SHA256SUMS.part
 7 b645e68d72511b0a739c2fcae512f31c6126adb43aa667d9bf325ba224d6fa9e  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf-debug.tar.gz
 8 cb2d9daf64014521fd491d6cfde151247d5ce26fcc02c048a0b87cc02a4efc35  guix-build-2a90059993b3/output/arm-linux-gnueabihf/bitcoin-2a90059993b3-arm-linux-gnueabihf.tar.gz
 9-f2e174c50b82b64c32e5e8b129c3d2060884ea1acd2e954fab65eb95658fa9a4  guix-build-2a90059993b3/output/arm64-apple-darwin/SHA256SUMS.part
10-288c5e306996f3dfbc3b4bd2681ec0faaa91e2c61b0bd14eefd0f4a0e8634a06  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.dmg
11-85c63680ac7fe5a2ac52a400d995817ac7480fb1868fff9484b036f691ce312f  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.tar.gz
12-cadd5b0e7c06db2856aecc10729af139969e9f36ba1a6ba26018a2e95d8348d2  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin.tar.gz
13+16bb9b4e714b3cdd1b9639769c933f4a2800d91b059a497eee4d063cf9fa8424  guix-build-2a90059993b3/output/arm64-apple-darwin/SHA256SUMS.part
14+240016945b021cb1826417cba1055ecc38a3e52d5c0326bd532e939afd816827  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.dmg
15+7542ae436ecd75f260a181807cd424c0fc0596208332dd9e58e1e48c2fa01638  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin-unsigned.tar.gz
16+c65723400bc1644210c8311bb41a81c2698ac219e233790b9bb361d9cdc23cd4  guix-build-2a90059993b3/output/arm64-apple-darwin/bitcoin-2a90059993b3-arm64-apple-darwin.tar.gz
17 a1172451dd685751c4d8be22109c9f363661e46e055ca42bee3aab9bd341cf56  guix-build-2a90059993b3/output/dist-archive/bitcoin-2a90059993b3.tar.gz
18 0009ca4894c1e1432456b1e7043546ebd8f1333d8e6c69c1f894ba7023df3cff  guix-build-2a90059993b3/output/powerpc64-linux-gnu/SHA256SUMS.part
19 b60539f7fd8ff07ac624eac090de86775552e6c58e760b21f0b2164de8c11cb2  guix-build-2a90059993b3/output/powerpc64-linux-gnu/bitcoin-2a90059993b3-powerpc64-linux-gnu-debug.tar.gz

hebasto force-pushed on Jul 18, 2022

fanquake added the label Build system on Jul 18, 2022

hebasto force-pushed on Jul 18, 2022

build: Add `double_conversion` package for Linux hosts 2a90059993

hebasto force-pushed on Jul 19, 2022

hebasto marked this as ready for review on Jul 19, 2022

fanquake commented at 9:45 am on July 19, 2022: member

I’m not completely convinced of this approach. We should first check if this fixes the arm64-apple-darwin build as well. Ideally we’d figure out the actual cause of the non-determinism, and fix it more directly, as this fixes the problem by shipping a binary that no-longer contains the affected code (at the cost of a new runtime dependency, and package to maintain in depends). Alternate approaches could be patching libdoubleconversion inside qt, or changing the optimisation flags for FastFixedDtoa

fanquake commented at 11:23 am on July 19, 2022: member

Alternate approaches could be patching libdoubleconversion inside qt, or changing the optimisation flags for FastFixedDtoa

Implemented this in #25643.

hebasto commented at 11:24 am on July 19, 2022: member

Closing in favor of #25643.

hebasto closed this on Jul 19, 2022

achow101 referenced this in commit 9c97ba5451 on Jul 19, 2022

sidhujag referenced this in commit 6f0ef72af6 on Jul 20, 2022

hebasto deleted the branch on Jul 27, 2022

bitcoin locked this on Jul 27, 2023

build: Add double_conversion package for Linux hosts #25636

build: Add `double_conversion` package for Linux hosts #25636