refactor: Remove unused includes from dbwrapper.h #25645

1. 
   MarcoFalke commented at 12:15 pm on July 19, 2022: member

   Unused includes are confusing, but also cause unrelated compile errors when the unused includes were to be removed.

   Fix that by adding the missing includes where they are needed and then remove them where they are not needed. This is also checked by iwyu.

2. Add missing includes to node/chainstate

   This is needed for the next commit

   fa869ce2c2
3. Add missing includes

   They are needed, otherwise the next commit will not compile

   fa77fdd047
4. 
   hebasto commented at 12:21 pm on July 19, 2022: member

   Concept ACK.
5. 
   fanquake commented at 12:29 pm on July 19, 2022: member

   ACK if green tidy. Could also include

   0rpc/fees.cpp should remove these lines:
   1- #include <policy/policy.h>  // lines 9-9
   2- #include <util/system.h>  // lines 19-19
   

6. Remove unused includes from dbwrapper.h 1111ddeedf
7. Remove unused includes in rpc/fees.cpp

   IWYU confirms that they are unused

   faf98aecf8
8. MarcoFalke force-pushed on Jul 19, 2022
9. hebasto approved
10. 
    hebasto commented at 12:39 pm on July 19, 2022: member

    ACK faf98aecf876fae0ec6d4d16b7e66f3a35253180, I have reviewed the code and it looks OK, I agree it can be merged.
11. 
    DrahtBot commented at 12:45 pm on July 19, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25623 ([kernel 3e/n] Decouple CDBWrapper and CBlockTreeDB from ArgsManager by dongcarl)
    • #25527 ([kernel 3c/n] Decouple validation cache initialization from ArgsManager by dongcarl)
    • #25172 (refactor: use std:: prefix for std lib funcs by fanquake)
    • #24833 (refactor: consensus/tx_verify.{h,cpp} tidy-ups by jonatack)
    • #24232 (assumeutxo: add init and completion logic by jamesob)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. MarcoFalke renamed this:
    Remove unused includes from dbwrapper.h
    refactor: Remove unused includes from dbwrapper.h
    on Jul 19, 2022
13. DrahtBot added the label Refactoring on Jul 19, 2022
14. 
    Sjors commented at 2:51 pm on July 19, 2022: member

    It indeed does look a bit confusing. But I can still build from scratch on macOS 12.4
15. jarolrod approved
16. 
    jarolrod commented at 7:07 pm on July 19, 2022: member

    Code Review ACK https://github.com/bitcoin/bitcoin/commit/faf98aecf876fae0ec6d4d16b7e66f3a35253180

    CI is green, compiled on ubuntu 22.04 and macOS 12.4 without issue, also ran tests.

17. fanquake merged this on Jul 19, 2022
18. fanquake closed this on Jul 19, 2022

    ---

19. sidhujag referenced this in commit 841586df8f on Jul 20, 2022
20. sidhujag referenced this in commit e52e1c3221 on Jul 20, 2022
21. MarcoFalke deleted the branch on Jul 20, 2022
22. bitcoin locked this on Jul 20, 2023

Contributors
MarcoFalke hebasto fanquake DrahtBot Sjors jarolrod

Labels
Refactoring