These were overlooked in ee30bf7c01922938bcf861a57cdf2249edb36256, and they will create problems when updating the secp256k1 subtree, see https://github.com/bitcoin-core/secp256k1/issues/1127.
build: remove left-over pkgconfig vars in config.site.in #25655
pull real-or-random wants to merge 1 commits into bitcoin:master from real-or-random:202207-pkgconfig-leftovers changing 1 files +0 −10-
real-or-random commented at 9:51 PM on July 20, 2022: contributor
-
36286ff52c
build: remove left-over pkgconfig vars in config.site.in
These were overlooked in ee30bf7c01922938bcf861a57cdf2249edb36256, and they will create problems when updating the secp256k1 subtree, see https://github.com/bitcoin-core/secp256k1/issues/1127.
- fanquake added the label Build system on Jul 20, 2022
-
real-or-random commented at 10:20 PM on July 20, 2022: contributor
Aha, the CI failures show that the variables are still necessary for other dependencies. (I wrongly assumed only secp256k1 is affected by config.site.in because that's the only package for which we call
AC_CONFIG_SUBS.)Then the right fix is probably to revert ee30bf7c01922938bcf861a57cdf2249edb36256 but let's first try to figure out if this will solve the issues with the subtree update.
- real-or-random closed this on Jul 20, 2022
- bitcoin locked this on Jul 20, 2023
Contributors
Labels