refactor: Fix iwyu on node/chainstate #25668

1. 
   MarcoFalke commented at 6:25 pm on July 21, 2022: member

   Fix the CI warning on master: https://cirrus-ci.com/task/5398182703136768?logs=ci#L7020
2. refactor: Fix iwyu on node/chainstate fad3c5826e
3. DrahtBot added the label Refactoring on Jul 21, 2022
4. 
   DrahtBot commented at 7:16 am on July 22, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25665 (BResult improvements, allow returning separate value on failure by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. fanquake approved
6. 
   fanquake commented at 7:38 am on July 22, 2022: member

   ACK fad3c5826e6618fa1d58b9be48972f4ef03a2103 - could do chain.h
7. 
   MarcoFalke commented at 7:46 am on July 22, 2022: member

   could do chain.h

   Wasn’t sure about that, as it was not yet added to iwyu. So it seems like a bug that there is a warning.

8. MarcoFalke merged this on Jul 22, 2022
9. MarcoFalke closed this on Jul 22, 2022

   ---

10. 
    fanquake commented at 7:49 am on July 22, 2022: member

    So it seems like a bug that there is a warning.

    Yea. Will follow up

11. MarcoFalke deleted the branch on Jul 22, 2022
12. 
    MarcoFalke commented at 7:51 am on July 22, 2022: member

    I mean we could also just add it explicitly to iwyu to work around the bug?
13. sidhujag referenced this in commit 1863205e91 on Jul 22, 2022
14. bitcoin locked this on Jul 22, 2023

Contributors
MarcoFalke DrahtBot fanquake

Labels
Refactoring