scripted-diff: Replace NullUniValue with UniValue::VNULL #25699

1. 
   MarcoFalke commented at 3:31 pm on July 25, 2022: member

   This refactor is needed to disable the (potentially expensive for large json) UniValue copy constructors.
2. fuzz: refactor: Replace NullUniValue with UniValue{}

   This is needed for the scripted-diff to compile in the next commit

   fa962103e8
3. scripted-diff: Replace NullUniValue with UniValue::VNULL

   This is required for removing the UniValue copy constructor.
   
   -BEGIN VERIFY SCRIPT-
    sed -i 's/return NullUniValue/return UniValue::VNULL/g' $(git grep -l NullUniValue ':(exclude)src/univalue')
   -END VERIFY SCRIPT-

   fa28d0f3c3
4. fanquake added the label Refactoring on Jul 25, 2022
5. luke-jr approved
6. 
   luke-jr commented at 4:33 pm on July 25, 2022: member

   Ugh @ the diff, but utACK because I can’t think of a better solution.
7. 
   DrahtBot commented at 6:21 pm on July 25, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24170 (p2p, rpc: Manual block-relay-only connections with addnode by mzumsande)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. fanquake approved
9. 
   fanquake commented at 9:07 am on July 26, 2022: member

   ACK fa28d0f3c3fe528dae7fd6dc7725219b9bdf0e1b
10. fanquake merged this on Jul 26, 2022
11. fanquake closed this on Jul 26, 2022

    ---

12. MarcoFalke deleted the branch on Jul 26, 2022
13. sidhujag referenced this in commit 3961df67e2 on Jul 27, 2022
14. bitcoin locked this on Jul 26, 2023

Contributors
MarcoFalke luke-jr DrahtBot fanquake

Labels
Refactoring