privacy: `add_inputs` argument for replacements to avoid adding unnecessary inputs #25776

This PR is an attempt to improve privacy by fixing #20935 and #20795 which was earlier tried in #21284

• Change the argument to boolean
• Rephrased a few things
• Co-author @danben

$ bitcoin-cli bumpfee <txid> "{\"add_inputs\": true}"

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #25344 (New outputs argument for bumpfee/psbtbumpfee by rodentrabies)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Given that this change is a copy of the changes from #21284, you should cherry-pick and use the commit from that PR. Rather than copy the changes into your own commit and add the original author as co-author.

A number of functional tests are currently failing.

Given that this change is a copy of the changes from #21284, you should cherry-pick and use the commit from that PR. Rather than copy the changes into your own commit and add the original author as co-author.

I avoided cherry pick because the file in which changes were made in past doesn't exist anymore (rpcwallet.cpp), coin_control.m_add_inputs doesnt exist anymore, argument was changed to boolean and false by default and rephrased few things.

A number of functional tests are currently failing.

Will try to fix it

<!--cf906140f33d8803c4a75a2196329ecb-->

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

Closing this as #25979 seems to be a better way to fix related issues