validation: change non-standard scriptpubkey error message. #25791

pull w0xlt wants to merge 1 commits into bitcoin:master from w0xlt:nonstandard_scriptpubkey changing 3 files +5 −5

w0xlt commented at 4:47 AM on August 6, 2022: contributor

scriptpubkey is not a clear error message. This PR changes it to non-standard-scriptpubkey, indicating the reason for the error.
DrahtBot added the label Validation on Aug 6, 2022
w0xlt force-pushed on Aug 6, 2022
w0xlt force-pushed on Aug 7, 2022
glozow commented at 4:02 PM on August 8, 2022: member

Concept NACK as the error code would already be MEMPOOL_REJECTED, i.e. mempool policy error, so adding "non-standard-" to the message does not provide any additional information.
validation: change non-standard scriptpubkey error message. f1c810b6c7

in src/policy/policy.cpp:135 in 6013d75ac1 outdated

 131 | @@ -132,7 +132,7 @@ bool IsStandardTx(const CTransaction& tx, const std::optional<unsigned>& max_dat
 132 |      TxoutType whichType;
 133 |      for (const CTxOut& txout : tx.vout) {
 134 |          if (!::IsStandard(txout.scriptPubKey, max_datacarrier_bytes, whichType)) {
 135 | -            reason = "scriptpubkey";
 136 | +            reason = "non-standard-scriptpubkey";

luke-jr commented at 1:06 AM on August 10, 2022:

scriptpubkey-nonstandard would fit the usual reject reason format better

w0xlt commented at 3:54 PM on August 10, 2022:

Done in https://github.com/bitcoin/bitcoin/pull/25791/commits/f1c810b6c7a17fa85f4eb075c061427fe59880ea.

w0xlt force-pushed on Aug 10, 2022
DrahtBot commented at 9:55 AM on September 23, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
fanquake commented at 10:03 AM on February 8, 2023: member

Closing for now. Doesn't seem to be any consensus on making this change. The PR descriptions claims that this would be more informative, but as mentioned, this doesn't really provide any additional information.
fanquake closed this on Feb 8, 2023
bitcoin locked this on Feb 8, 2024

Contributors

Labels

validation: change non-standard scriptpubkey error message. #25791

Conflicts