test, tracing: don't rely on `block_connected` USDT event order in tests #25794

pull 0xB10C wants to merge 1 commits into bitcoin:master from 0xB10C:2022-08-fix-usdt-validation-test changing 1 files +6 −5

0xB10C commented at 12:00 PM on August 6, 2022: contributor

Relying on block_connected event order in the USDT interface tests turned out to be brittle.

Closes #25793 Closes https://github.com/bitcoin/bitcoin/issues/25764

test: don't rely on usdt block_conn event order

Relying on block_connected event order in the USDT interface tests
turned out to be brittle.

Fixes https://github.com/bitcoin/bitcoin/issues/25793
Fixes https://github.com/bitcoin/bitcoin/issues/25764

0532aa7444

fanquake added the label Tests on Aug 6, 2022
w0xlt commented at 6:10 AM on August 8, 2022: contributor

Approach ACK
0xB10C commented at 11:45 AM on August 8, 2022: contributor

I've been re-running this in the CI to spot if it breaks again: https://cirrus-ci.com/task/6515285560655872

edit: 15+ CI passes in a row now
jb55 commented at 2:06 PM on August 8, 2022: contributor

ACK
MarcoFalke merged this on Aug 10, 2022
MarcoFalke closed this on Aug 10, 2022
0xB10C deleted the branch on Aug 10, 2022
sidhujag referenced this in commit 979c35aeb8 on Aug 10, 2022
bitcoin locked this on Aug 10, 2023

Contributors

Labels

Linked (view graph)

#25764 test: failure in interface_usdt_validation.py #25793 Spurious CI failure of `interface_usdt_validation.py`